Re: [PATCH 2/8] qapi/qom: Introduce smp-cache object

2024-07-25 Thread Zhao Liu
Thanks Jonathon! On Thu, Jul 25, 2024 at 11:59:02AM +0100, Jonathan Cameron wrote: [snip] > > > I think I understand why you want to configure caches. My question was > > > about the connection to SMP. > > > > > > Say we run a guest with a single core, no SMP. Could configuring caches > > > s

Re: [PATCH 2/8] qapi/qom: Introduce smp-cache object

2024-07-25 Thread Zhao Liu
Hi Markus, On Thu, Jul 25, 2024 at 10:51:49AM +0200, Markus Armbruster wrote: [snip] > >> What's the use case? The commit messages don't tell. > > > > i386 has the default cache topology model: l1 per core/l2 per core/l3 > > per die. > > > > Cache topology affects scheduler performance, e.g., k

Re: [PATCH 2/8] qapi/qom: Introduce smp-cache object

2024-07-25 Thread Jonathan Cameron via
On Thu, 25 Jul 2024 11:50:59 +0100 Jonathan Cameron wrote: Resending as this bounced due (I think) to an address typo. > Hi Markus, Zhao Liu > > From the ARM server side this is something I want to see as well. > So I can comment on why we care. > > > >> This series adds a way to configure cac

Re: [PATCH 2/8] qapi/qom: Introduce smp-cache object

2024-07-25 Thread Markus Armbruster
Zhao Liu writes: > Hi Markus, > > I realized I should reply this mail first... > > On Wed, Jul 24, 2024 at 01:35:17PM +0200, Markus Armbruster wrote: >> Date: Wed, 24 Jul 2024 13:35:17 +0200 >> From: Markus Armbruster >> Subject: Re: [PATCH 2/8] qapi/qom: Intro

Re: [PATCH 2/8] qapi/qom: Introduce smp-cache object

2024-07-24 Thread Zhao Liu
Hi Daniel, On Wed, Jul 24, 2024 at 10:03:02PM +0800, Zhao Liu wrote: > Date: Wed, 24 Jul 2024 22:03:02 +0800 > From: Zhao Liu > Subject: Re: [PATCH 2/8] qapi/qom: Introduce smp-cache object > > On Wed, Jul 24, 2024 at 01:47:16PM +0100, Daniel P. Berrang? wrote: > > Date: W

Re: [PATCH 2/8] qapi/qom: Introduce smp-cache object

2024-07-24 Thread Zhao Liu
Hi Markus, I realized I should reply this mail first... On Wed, Jul 24, 2024 at 01:35:17PM +0200, Markus Armbruster wrote: > Date: Wed, 24 Jul 2024 13:35:17 +0200 > From: Markus Armbruster > Subject: Re: [PATCH 2/8] qapi/qom: Introduce smp-cache object > > Zhao Liu writes: &

Re: [PATCH 2/8] qapi/qom: Introduce smp-cache object

2024-07-24 Thread Zhao Liu
On Wed, Jul 24, 2024 at 01:47:16PM +0100, Daniel P. Berrangé wrote: > Date: Wed, 24 Jul 2024 13:47:16 +0100 > From: "Daniel P. Berrangé" > Subject: Re: [PATCH 2/8] qapi/qom: Introduce smp-cache object > > On Wed, Jul 24, 2024 at 01:35:17PM +0200, Markus Armbruster wr

Re: [PATCH 2/8] qapi/qom: Introduce smp-cache object

2024-07-24 Thread Daniel P . Berrangé
On Wed, Jul 24, 2024 at 01:35:17PM +0200, Markus Armbruster wrote: > Zhao Liu writes: > > > Hi Markus, > >> SmpCachesProperties and SmpCacheProperties would put the singular > >> vs. plural where it belongs. Sounds a bit awkward to me, though. > >> Naming is hard. > > > > For SmpCachesProperties

Re: [PATCH 2/8] qapi/qom: Introduce smp-cache object

2024-07-24 Thread Markus Armbruster
Zhao Liu writes: > Hi Markus, > > On Mon, Jul 22, 2024 at 03:33:13PM +0200, Markus Armbruster wrote: >> Date: Mon, 22 Jul 2024 15:33:13 +0200 >> From: Markus Armbruster >> Subject: Re: [PATCH 2/8] qapi/qom: Introduce smp-cache object >> >> Zhao Liu writ

Re: [PATCH 2/8] qapi/qom: Introduce smp-cache object

2024-07-22 Thread Zhao Liu
Hi Markus, On Mon, Jul 22, 2024 at 03:33:13PM +0200, Markus Armbruster wrote: > Date: Mon, 22 Jul 2024 15:33:13 +0200 > From: Markus Armbruster > Subject: Re: [PATCH 2/8] qapi/qom: Introduce smp-cache object > > Zhao Liu writes: > > > Introduce smp-cache object so that

Re: [PATCH 2/8] qapi/qom: Introduce smp-cache object

2024-07-22 Thread Markus Armbruster
Zhao Liu writes: > Introduce smp-cache object so that user could define cache properties. > > In smp-cache object, define cache topology based on CPU topology level > with two reasons: > > 1. In practice, a cache will always be bound to the CPU container >(either private in the CPU container

Re: [PATCH 2/8] qapi/qom: Introduce smp-cache object

2024-07-09 Thread Zhao Liu
> diff --git a/hw/core/smp-cache.c b/hw/core/smp-cache.c > new file mode 100644 > index ..c0157ce51c8f > --- /dev/null > +++ b/hw/core/smp-cache.c > @@ -0,0 +1,103 @@ > +/* > + * Cache Object for SMP machine > + * > + * Copyright (C) 2024 Intel Corporation. > + * > + * Author: Zhao Liu

[PATCH 2/8] qapi/qom: Introduce smp-cache object

2024-07-03 Thread Zhao Liu
Introduce smp-cache object so that user could define cache properties. In smp-cache object, define cache topology based on CPU topology level with two reasons: 1. In practice, a cache will always be bound to the CPU container (either private in the CPU container or shared among multiple con