Re: [PATCH 2/7] python/qemu: formalize as package

2020-06-05 Thread John Snow
On 6/5/20 10:40 AM, Vladimir Sementsov-Ogievskiy wrote: > > Hmm, documentation says: > >    Warning Using setup_requires is discouraged in favor of PEP-518 > > did you consider this thing? I guess the difference here is we start using a pyproject.toml and then we declare setuptools, wheel an

Re: [PATCH 2/7] python/qemu: formalize as package

2020-06-05 Thread John Snow
On 6/5/20 10:40 AM, Vladimir Sementsov-Ogievskiy wrote: > 03.06.2020 03:15, John Snow wrote: >> NB: I am choosing Python 3.6 here. Although our minimum requirement is >> 3.5, this code is used only by iotests (so far) under which we have been >> using a minimum version of 3.6. >> >> 3.6 is being

Re: [PATCH 2/7] python/qemu: formalize as package

2020-06-05 Thread Vladimir Sementsov-Ogievskiy
03.06.2020 03:15, John Snow wrote: NB: I am choosing Python 3.6 here. Although our minimum requirement is 3.5, this code is used only by iotests (so far) under which we have been using a minimum version of 3.6. 3.6 is being preferred here for variable type hint capability, which enables us to us

[PATCH 2/7] python/qemu: formalize as package

2020-06-02 Thread John Snow
NB: I am choosing Python 3.6 here. Although our minimum requirement is 3.5, this code is used only by iotests (so far) under which we have been using a minimum version of 3.6. 3.6 is being preferred here for variable type hint capability, which enables us to use mypy for this package. RFC: This u