Re: [PATCH 2/6] migration: Fix migrate-set-parameters argument validation

2020-11-13 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> Commit 741d4086c8 "migration: Use proper types in json" (v2.12.0) >> switched MigrationParameters to narrower integer types, and removed >> the simplified qmp_migrate_set_parameters()'s argument checking >> accor

Re: [PATCH 2/6] migration: Fix migrate-set-parameters argument validation

2020-11-13 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Commit 741d4086c8 "migration: Use proper types in json" (v2.12.0) > switched MigrationParameters to narrower integer types, and removed > the simplified qmp_migrate_set_parameters()'s argument checking > accordingly. > > Good idea, except qmp_migrat

[PATCH 2/6] migration: Fix migrate-set-parameters argument validation

2020-11-12 Thread Markus Armbruster
Commit 741d4086c8 "migration: Use proper types in json" (v2.12.0) switched MigrationParameters to narrower integer types, and removed the simplified qmp_migrate_set_parameters()'s argument checking accordingly. Good idea, except qmp_migrate_set_parameters() takes MigrateSetParameters, not Migratio