Re: [PATCH 2/6] contrib/plugins/cache: fix warning when compiling on 32bits host

2024-08-16 Thread Richard Henderson
On 8/16/24 22:47, Alex Bennée wrote: No, not a bug. This is a host addr, right there in the name. Returning uint64_t would be a bug. No it's: * Returns: hardware (physical) target address of instruction I was kinda assuming that was what the underlying host_addr[] fields in DisasContextDB

Re: [PATCH 2/6] contrib/plugins/cache: fix warning when compiling on 32bits host

2024-08-16 Thread Peter Maydell
On Fri, 16 Aug 2024 at 13:48, Alex Bennée wrote: > > Richard Henderson writes: > > > On 8/15/24 21:46, Alex Bennée wrote: > >> Thomas Huth writes: > >> > >>> On 15/08/2024 01.36, Pierrick Bouvier wrote: > Found on debian stable (i386). > ../contrib/plugins/cache.c: In function 'vcpu_tb

Re: [PATCH 2/6] contrib/plugins/cache: fix warning when compiling on 32bits host

2024-08-16 Thread Alex Bennée
Pierrick Bouvier writes: > On 8/15/24 04:46, Alex Bennée wrote: >> Thomas Huth writes: >> >>> On 15/08/2024 01.36, Pierrick Bouvier wrote: Found on debian stable (i386). ../contrib/plugins/cache.c: In function 'vcpu_tb_trans': ../contrib/plugins/cache.c:477:30: error: cast from p

Re: [PATCH 2/6] contrib/plugins/cache: fix warning when compiling on 32bits host

2024-08-16 Thread Alex Bennée
Richard Henderson writes: > On 8/15/24 21:46, Alex Bennée wrote: >> Thomas Huth writes: >> >>> On 15/08/2024 01.36, Pierrick Bouvier wrote: Found on debian stable (i386). ../contrib/plugins/cache.c: In function 'vcpu_tb_trans': ../contrib/plugins/cache.c:477:30: error: cast from

Re: [PATCH 2/6] contrib/plugins/cache: fix warning when compiling on 32bits host

2024-08-15 Thread Pierrick Bouvier
On 8/15/24 10:38, Pierrick Bouvier wrote: On 8/15/24 04:46, Alex Bennée wrote: Thomas Huth writes: On 15/08/2024 01.36, Pierrick Bouvier wrote: Found on debian stable (i386). ../contrib/plugins/cache.c: In function 'vcpu_tb_trans': ../contrib/plugins/cache.c:477:30: error: cast from pointer

Re: [PATCH 2/6] contrib/plugins/cache: fix warning when compiling on 32bits host

2024-08-15 Thread Richard Henderson
On 8/15/24 21:46, Alex Bennée wrote: Thomas Huth writes: On 15/08/2024 01.36, Pierrick Bouvier wrote: Found on debian stable (i386). ../contrib/plugins/cache.c: In function 'vcpu_tb_trans': ../contrib/plugins/cache.c:477:30: error: cast from pointer to integer of different size [-Werror=poin

Re: [PATCH 2/6] contrib/plugins/cache: fix warning when compiling on 32bits host

2024-08-15 Thread Pierrick Bouvier
On 8/15/24 04:46, Alex Bennée wrote: Thomas Huth writes: On 15/08/2024 01.36, Pierrick Bouvier wrote: Found on debian stable (i386). ../contrib/plugins/cache.c: In function 'vcpu_tb_trans': ../contrib/plugins/cache.c:477:30: error: cast from pointer to integer of different size [-Werror=poin

Re: [PATCH 2/6] contrib/plugins/cache: fix warning when compiling on 32bits host

2024-08-15 Thread Alex Bennée
Thomas Huth writes: > On 15/08/2024 01.36, Pierrick Bouvier wrote: >> Found on debian stable (i386). >> ../contrib/plugins/cache.c: In function 'vcpu_tb_trans': >> ../contrib/plugins/cache.c:477:30: error: cast from pointer to integer of >> different size [-Werror=pointer-to-int-cast] >>477

Re: [PATCH 2/6] contrib/plugins/cache: fix warning when compiling on 32bits host

2024-08-15 Thread Thomas Huth
On 15/08/2024 01.36, Pierrick Bouvier wrote: Found on debian stable (i386). ../contrib/plugins/cache.c: In function 'vcpu_tb_trans': ../contrib/plugins/cache.c:477:30: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] 477 | effective_addr = (uint

[PATCH 2/6] contrib/plugins/cache: fix warning when compiling on 32bits host

2024-08-14 Thread Pierrick Bouvier
Found on debian stable (i386). ../contrib/plugins/cache.c: In function 'vcpu_tb_trans': ../contrib/plugins/cache.c:477:30: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] 477 | effective_addr = (uint64_t) qemu_plugin_insn_haddr(insn); | Sig