Re: [PATCH 2/5] dump: Fix g_array_unref(NULL) in dump-guest-memory

2023-10-31 Thread Marc-André Lureau
Hi On Tue, Oct 31, 2023 at 1:06 PM Markus Armbruster wrote: > > Markus Armbruster writes: > > > Marc-André Lureau writes: > > > >> Hi > >> > >> On Mon, Oct 30, 2023 at 5:37 PM Markus Armbruster > >> wrote: > >>> > >>> When dump_init()'s check for non-zero @length fails, dump_cleanup() > >>> p

Re: [PATCH 2/5] dump: Fix g_array_unref(NULL) in dump-guest-memory

2023-10-31 Thread Markus Armbruster
Markus Armbruster writes: > Marc-André Lureau writes: > >> Hi >> >> On Mon, Oct 30, 2023 at 5:37 PM Markus Armbruster wrote: >>> >>> When dump_init()'s check for non-zero @length fails, dump_cleanup() >>> passes null s->string_table_buf to g_array_unref(), which spews "GLib: >>> g_array_unref:

Re: [PATCH 2/5] dump: Fix g_array_unref(NULL) in dump-guest-memory

2023-10-31 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Mon, Oct 30, 2023 at 5:37 PM Markus Armbruster wrote: >> >> When dump_init()'s check for non-zero @length fails, dump_cleanup() >> passes null s->string_table_buf to g_array_unref(), which spews "GLib: >> g_array_unref: assertion 'array' failed" to stderr. >

Re: [PATCH 2/5] dump: Fix g_array_unref(NULL) in dump-guest-memory

2023-10-30 Thread Marc-André Lureau
Hi On Mon, Oct 30, 2023 at 5:37 PM Markus Armbruster wrote: > > When dump_init()'s check for non-zero @length fails, dump_cleanup() > passes null s->string_table_buf to g_array_unref(), which spews "GLib: > g_array_unref: assertion 'array' failed" to stderr. > > Guard the g_array_unref(). > > Sig

[PATCH 2/5] dump: Fix g_array_unref(NULL) in dump-guest-memory

2023-10-30 Thread Markus Armbruster
When dump_init()'s check for non-zero @length fails, dump_cleanup() passes null s->string_table_buf to g_array_unref(), which spews "GLib: g_array_unref: assertion 'array' failed" to stderr. Guard the g_array_unref(). Signed-off-by: Markus Armbruster --- dump/dump.c | 4 +++- 1 file changed, 3