Re: [PATCH 2/4] smbus: Fix spd_data_generate() error API violation

2020-04-28 Thread Markus Armbruster
BALATON Zoltan writes: > On Fri, 24 Apr 2020, Markus Armbruster wrote: >> BALATON Zoltan writes: >>> On Tue, 21 Apr 2020, Markus Armbruster wrote: BALATON Zoltan writes: > On Mon, 20 Apr 2020, Markus Armbruster wrote: >> The Error ** argument must be NULL, &error_abort, &error_fata

Re: [PATCH 2/4] smbus: Fix spd_data_generate() error API violation

2020-04-24 Thread BALATON Zoltan
On Fri, 24 Apr 2020, Markus Armbruster wrote: BALATON Zoltan writes: On Tue, 21 Apr 2020, Markus Armbruster wrote: BALATON Zoltan writes: On Mon, 20 Apr 2020, Markus Armbruster wrote: The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL.

Re: [PATCH 2/4] smbus: Fix spd_data_generate() error API violation

2020-04-24 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 4/24/20 11:45 AM, Markus Armbruster wrote: >> BALATON Zoltan writes: >>> On Tue, 21 Apr 2020, Markus Armbruster wrote: > [...] Here's what I actually disagree with: 1. QEMU warning the user about its choice of memory type, but only som

Re: [PATCH 2/4] smbus: Fix spd_data_generate() error API violation

2020-04-24 Thread Philippe Mathieu-Daudé
On 4/24/20 11:45 AM, Markus Armbruster wrote: BALATON Zoltan writes: On Tue, 21 Apr 2020, Markus Armbruster wrote: [...] Here's what I actually disagree with: 1. QEMU warning the user about its choice of memory type, but only sometimes. Why warn? There is nothing wrong, and there is nothi

Re: [PATCH 2/4] smbus: Fix spd_data_generate() error API violation

2020-04-24 Thread Markus Armbruster
BALATON Zoltan writes: > On Tue, 21 Apr 2020, Markus Armbruster wrote: >> BALATON Zoltan writes: >>> On Mon, 20 Apr 2020, Markus Armbruster wrote: The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the >>>

Re: [PATCH 2/4] smbus: Fix spd_data_generate() error API violation

2020-04-22 Thread BALATON Zoltan
On Tue, 21 Apr 2020, Markus Armbruster wrote: BALATON Zoltan writes: On Mon, 20 Apr 2020, Markus Armbruster wrote: The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in be

Re: [PATCH 2/4] smbus: Fix spd_data_generate() error API violation

2020-04-20 Thread Markus Armbruster
BALATON Zoltan writes: > On Mon, 20 Apr 2020, Markus Armbruster wrote: >> The Error ** argument must be NULL, &error_abort, &error_fatal, or a >> pointer to a variable containing NULL. Passing an argument of the >> latter kind twice without clearing it in between is wrong: if the >> first call s

Re: [PATCH 2/4] smbus: Fix spd_data_generate() error API violation

2020-04-20 Thread BALATON Zoltan
On Mon, 20 Apr 2020, Markus Armbruster wrote: The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to

[PATCH 2/4] smbus: Fix spd_data_generate() error API violation

2020-04-20 Thread Markus Armbruster
The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. spd_data_generate() c