Re: [PATCH 2/4] qtest: replace gettimeofday with GTimer

2022-03-04 Thread Marc-André Lureau
Hi Richard On Sat, Mar 5, 2022 at 12:50 AM Richard Henderson wrote: > > On 3/4/22 05:27, marcandre.lur...@redhat.com wrote: > > +g_clear_pointer(&timer, g_timer_destroy); > > +timer = g_timer_new(); > > Why not g_timer_{reset,start}, instead of destroying and recreating? Well, th

Re: [PATCH 2/4] qtest: replace gettimeofday with GTimer

2022-03-04 Thread Richard Henderson
On 3/4/22 05:27, marcandre.lur...@redhat.com wrote: +g_clear_pointer(&timer, g_timer_destroy); +timer = g_timer_new(); Why not g_timer_{reset,start}, instead of destroying and recreating? r~

Re: [PATCH 2/4] qtest: replace gettimeofday with GTimer

2022-03-04 Thread Laurent Vivier
Le 04/03/2022 à 16:54, Laurent Vivier a écrit : Le 04/03/2022 à 16:27, marcandre.lur...@redhat.com a écrit : From: Marc-André Lureau glib provides a convenience helper to measure elapsed time. It isn't subject to wall-clock time changes. Note that this changes the initial OPENED time, which u

Re: [PATCH 2/4] qtest: replace gettimeofday with GTimer

2022-03-04 Thread Laurent Vivier
Le 04/03/2022 à 16:27, marcandre.lur...@redhat.com a écrit : From: Marc-André Lureau glib provides a convenience helper to measure elapsed time. It isn't subject to wall-clock time changes. Note that this changes the initial OPENED time, which used to print the current time. Time is printed

[PATCH 2/4] qtest: replace gettimeofday with GTimer

2022-03-04 Thread marcandre . lureau
From: Marc-André Lureau glib provides a convenience helper to measure elapsed time. It isn't subject to wall-clock time changes. Note that this changes the initial OPENED time, which used to print the current time. Signed-off-by: Marc-André Lureau --- softmmu/qtest.c | 39 ++--