Re: [PATCH 2/4] coroutine: Add check for SafeStack in sigalstack

2020-05-27 Thread Daniele Buono
Sorry, missed the question at the end of the email. Will change the commit and error message to explain better in v2. Similar to the ucontext, case, sigaltstack does not work out of the box because it requires a stack to be allocated by the user. I'll be honest, I didn't check the details of how

Re: [PATCH 2/4] coroutine: Add check for SafeStack in sigalstack

2020-05-21 Thread Stefan Hajnoczi
On Wed, Apr 29, 2020 at 03:44:18PM -0400, Daniele Buono wrote: s/sigalstack/sigaltstack/ in the commit message. > LLVM's SafeStack instrumentation cannot be used inside signal handlers > that make use of sigaltstack(). > Since coroutine-sigaltstack relies on sigaltstack(), it is not > compatible

Re: [PATCH 2/4] coroutine: Add check for SafeStack in sigalstack

2020-05-04 Thread Philippe Mathieu-Daudé
On 4/29/20 9:44 PM, Daniele Buono wrote: LLVM's SafeStack instrumentation cannot be used inside signal handlers that make use of sigaltstack(). Since coroutine-sigaltstack relies on sigaltstack(), it is not compatible with SafeStack. The resulting binary is incorrect, with different coroutines sh

[PATCH 2/4] coroutine: Add check for SafeStack in sigalstack

2020-04-29 Thread Daniele Buono
LLVM's SafeStack instrumentation cannot be used inside signal handlers that make use of sigaltstack(). Since coroutine-sigaltstack relies on sigaltstack(), it is not compatible with SafeStack. The resulting binary is incorrect, with different coroutines sharing the same unsafe stack and producing u