Re: [PATCH 2/3] virtio-net: Only enable userland vq if using tap backend

2021-11-21 Thread Jason Wang
On Mon, Nov 22, 2021 at 2:24 PM Eugenio Perez Martin wrote: > > On Mon, Nov 22, 2021 at 3:39 AM Jason Wang wrote: > > > > On Fri, Nov 19, 2021 at 3:50 PM Eugenio Perez Martin > > wrote: > > > > > > On Fri, Nov 19, 2021 at 3:44 AM Jason Wang wrote: > > > > > > > > On Thu, Nov 18, 2021 at 3:57 PM

Re: [PATCH 2/3] virtio-net: Only enable userland vq if using tap backend

2021-11-21 Thread Eugenio Perez Martin
On Mon, Nov 22, 2021 at 3:39 AM Jason Wang wrote: > > On Fri, Nov 19, 2021 at 3:50 PM Eugenio Perez Martin > wrote: > > > > On Fri, Nov 19, 2021 at 3:44 AM Jason Wang wrote: > > > > > > On Thu, Nov 18, 2021 at 3:57 PM Eugenio Perez Martin > > > wrote: > > > > > > > > On Thu, Nov 18, 2021 at 6:0

Re: [PATCH 2/3] virtio-net: Only enable userland vq if using tap backend

2021-11-21 Thread Jason Wang
On Fri, Nov 19, 2021 at 3:50 PM Eugenio Perez Martin wrote: > > On Fri, Nov 19, 2021 at 3:44 AM Jason Wang wrote: > > > > On Thu, Nov 18, 2021 at 3:57 PM Eugenio Perez Martin > > wrote: > > > > > > On Thu, Nov 18, 2021 at 6:06 AM Jason Wang wrote: > > > > > > > > On Thu, Nov 18, 2021 at 3:29 AM

Re: [PATCH 2/3] virtio-net: Only enable userland vq if using tap backend

2021-11-18 Thread Eugenio Perez Martin
On Fri, Nov 19, 2021 at 3:44 AM Jason Wang wrote: > > On Thu, Nov 18, 2021 at 3:57 PM Eugenio Perez Martin > wrote: > > > > On Thu, Nov 18, 2021 at 6:06 AM Jason Wang wrote: > > > > > > On Thu, Nov 18, 2021 at 3:29 AM Eugenio Pérez wrote: > > > > > > > > Qemu falls back on userland handlers eve

Re: [PATCH 2/3] virtio-net: Only enable userland vq if using tap backend

2021-11-18 Thread Jason Wang
On Thu, Nov 18, 2021 at 3:57 PM Eugenio Perez Martin wrote: > > On Thu, Nov 18, 2021 at 6:06 AM Jason Wang wrote: > > > > On Thu, Nov 18, 2021 at 3:29 AM Eugenio Pérez wrote: > > > > > > Qemu falls back on userland handlers even if vhost-user and vhost-vdpa > > > cases. These assumes a tap devic

Re: [PATCH 2/3] virtio-net: Only enable userland vq if using tap backend

2021-11-17 Thread Eugenio Perez Martin
On Thu, Nov 18, 2021 at 6:06 AM Jason Wang wrote: > > On Thu, Nov 18, 2021 at 3:29 AM Eugenio Pérez wrote: > > > > Qemu falls back on userland handlers even if vhost-user and vhost-vdpa > > cases. These assumes a tap device can handle the packets. > > > > If a vdpa device fail to start, it can tr

Re: [PATCH 2/3] virtio-net: Only enable userland vq if using tap backend

2021-11-17 Thread Jason Wang
On Thu, Nov 18, 2021 at 3:29 AM Eugenio Pérez wrote: > > Qemu falls back on userland handlers even if vhost-user and vhost-vdpa > cases. These assumes a tap device can handle the packets. > > If a vdpa device fail to start, it can trigger a sigsegv because of > that. Do not resort on them unless a

[PATCH 2/3] virtio-net: Only enable userland vq if using tap backend

2021-11-17 Thread Eugenio Pérez
Qemu falls back on userland handlers even if vhost-user and vhost-vdpa cases. These assumes a tap device can handle the packets. If a vdpa device fail to start, it can trigger a sigsegv because of that. Do not resort on them unless actually possible. Signed-off-by: Eugenio Pérez --- include/hw/