Re: [PATCH 2/3] qapi: blockdev-backup: add discard-source parameter

2024-01-12 Thread Vladimir Sementsov-Ogievskiy
Hi Fiona! That was the only version, because it was based on "[PATCH v5 00/45] Transactional block-graph modifying API", as written in commit message. And "[PATCH v5 00/45] Transactional block-graph modifying API" was not merged, instead I decided to send it part-by-part, some were already mer

Re: [PATCH 2/3] qapi: blockdev-backup: add discard-source parameter

2024-01-11 Thread Fiona Ebner
Hi Vladimir, hope I didn't miss a newer version of this series. I'm currently evaluating fleecing backup for Proxmox downstream, so I pulled in this series and wanted to let you know about two issues I encountered while testing. We are still based on 8.1, but if I'm not mistaken, they are still re

[PATCH 2/3] qapi: blockdev-backup: add discard-source parameter

2022-03-31 Thread Vladimir Sementsov-Ogievskiy
Add a parameter that enables discard-after-copy. That is mostly useful in "push backup with fleecing" scheme, when source is snapshot-access format driver node, based on copy-before-write filter snapshot-access API: [guest] [snapshot-access] ~~ blockdev-backup ~~> [backup target] |