Re: [PATCH 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-08 Thread Claudio Fontana
On 9/8/22 10:11, Richard Henderson wrote: > On 9/6/22 12:55, Claudio Fontana wrote: >> improve error handling during module load, by changing: >> >> bool module_load_one(const char *prefix, const char *lib_name); >> void module_load_qom_one(const char *type); >> >> to: >> >> bool module_load_one(co

Re: [PATCH 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-08 Thread Claudio Fontana
Hi Richard, thanks for looking at this, On 9/8/22 10:11, Richard Henderson wrote: > On 9/6/22 12:55, Claudio Fontana wrote: >> improve error handling during module load, by changing: >> >> bool module_load_one(const char *prefix, const char *lib_name); >> void module_load_qom_one(const char *type)

Re: [PATCH 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-08 Thread Richard Henderson
On 9/6/22 12:55, Claudio Fontana wrote: improve error handling during module load, by changing: bool module_load_one(const char *prefix, const char *lib_name); void module_load_qom_one(const char *type); to: bool module_load_one(const char *prefix, const char *name, Error **errp); bool module_

Re: [PATCH 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-07 Thread Claudio Fontana
On 9/7/22 09:36, Gerd Hoffmann wrote: > Hi, > >> For this module_load_qom_all() maybe Gerd has a bit more context on >> was should be the error reporting here? > > Use case for module_load_qom_all() is someone enumerating the qom > objects available. So we load all modules known to have all o

Re: [PATCH 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-07 Thread Claudio Fontana
On 9/6/22 13:55, Claudio Fontana wrote: > improve error handling during module load, by changing: > > bool module_load_one(const char *prefix, const char *lib_name); > void module_load_qom_one(const char *type); > > to: > > bool module_load_one(const char *prefix, const char *name, Error **errp)

Re: [PATCH 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-07 Thread Gerd Hoffmann
Hi, > For this module_load_qom_all() maybe Gerd has a bit more context on > was should be the error reporting here? Use case for module_load_qom_all() is someone enumerating the qom objects available. So we load all modules known to have all object types registered and can return a complete l

Re: [PATCH 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-06 Thread Philippe Mathieu-Daudé via
+Markus On 6/9/22 14:32, Claudio Fontana wrote: On 9/6/22 13:55, Claudio Fontana wrote: improve error handling during module load, by changing: bool module_load_one(const char *prefix, const char *lib_name); void module_load_qom_one(const char *type); to: bool module_load_one(const char *pre

Re: [PATCH 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-06 Thread Claudio Fontana
On 9/6/22 13:55, Claudio Fontana wrote: > improve error handling during module load, by changing: > > bool module_load_one(const char *prefix, const char *lib_name); > void module_load_qom_one(const char *type); > > to: > > bool module_load_one(const char *prefix, const char *name, Error **errp)

[PATCH 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-06 Thread Claudio Fontana
improve error handling during module load, by changing: bool module_load_one(const char *prefix, const char *lib_name); void module_load_qom_one(const char *type); to: bool module_load_one(const char *prefix, const char *name, Error **errp); bool module_load_qom_one(const char *type, Error **err