RE: [PATCH 2/3] intel_iommu: Add missed sanity check for 256-bit invalidation queue

2024-11-05 Thread Duan, Zhenzhong
>-Original Message- >From: Liu, Yi L >Sent: Tuesday, November 5, 2024 2:50 PM >Subject: Re: [PATCH 2/3] intel_iommu: Add missed sanity check for 256-bit >invalidation queue > >On 2024/11/5 14:12, Duan, Zhenzhong wrote: >> >> >>> -Original

Re: [PATCH 2/3] intel_iommu: Add missed sanity check for 256-bit invalidation queue

2024-11-05 Thread CLEMENT MATHIEU--DRIF
t: Tuesday, November 5, 2024 2:36 PM >> Subject: Re: [PATCH 2/3] intel_iommu: Add missed sanity check for 256-bit >> invalidation queue >> >> I saw the pull request, just a few questions/comments in case there is a >> new spin. >> These are not hard requirements,

RE: [PATCH 2/3] intel_iommu: Add missed sanity check for 256-bit invalidation queue

2024-11-04 Thread Duan, Zhenzhong
>-Original Message- >From: CLEMENT MATHIEU--DRIF >Sent: Tuesday, November 5, 2024 2:36 PM >Subject: Re: [PATCH 2/3] intel_iommu: Add missed sanity check for 256-bit >invalidation queue > >I saw the pull request, just a few questions/comments in case there is a >

Re: [PATCH 2/3] intel_iommu: Add missed sanity check for 256-bit invalidation queue

2024-11-04 Thread Yi Liu
On 2024/11/5 14:12, Duan, Zhenzhong wrote: -Original Message- From: Liu, Yi L Sent: Tuesday, November 5, 2024 1:05 PM Subject: Re: [PATCH 2/3] intel_iommu: Add missed sanity check for 256-bit invalidation queue On 2024/11/4 20:55, Zhenzhong Duan wrote: According to VTD spec, a 256

Re: [PATCH 2/3] intel_iommu: Add missed sanity check for 256-bit invalidation queue

2024-11-04 Thread CLEMENT MATHIEU--DRIF
I saw the pull request, just a few questions/comments in case there is a new spin. These are not hard requirements, the current version looks good as well. On 04/11/2024 13:55, Zhenzhong Duan wrote: > Caution: External email. Do not open attachments or click links, unless this > email comes from

RE: [PATCH 2/3] intel_iommu: Add missed sanity check for 256-bit invalidation queue

2024-11-04 Thread Duan, Zhenzhong
>-Original Message- >From: Liu, Yi L >Sent: Tuesday, November 5, 2024 1:05 PM >Subject: Re: [PATCH 2/3] intel_iommu: Add missed sanity check for 256-bit >invalidation queue > >On 2024/11/4 20:55, Zhenzhong Duan wrote: >> According to VTD spec, a 256-bit d

Re: [PATCH 2/3] intel_iommu: Add missed sanity check for 256-bit invalidation queue

2024-11-04 Thread Yi Liu
On 2024/11/4 20:55, Zhenzhong Duan wrote: According to VTD spec, a 256-bit descriptor will result in an invalid descriptor error if submitted in an IQ that is setup to provide hardware with 128-bit descriptors (IQA_REG.DW=0). Meanwhile, there are old inv desc types (e.g. iotlb_inv_desc) that can

RE: [PATCH 2/3] intel_iommu: Add missed sanity check for 256-bit invalidation queue

2024-11-04 Thread Duan, Zhenzhong
>-Original Message- >From: Michael S. Tsirkin >Subject: Re: [PATCH 2/3] intel_iommu: Add missed sanity check for 256-bit >invalidation queue > >On Mon, Nov 04, 2024 at 08:55:35PM +0800, Zhenzhong Duan wrote: >> According to VTD spec, a 256-bit descriptor w

Re: [PATCH 2/3] intel_iommu: Add missed sanity check for 256-bit invalidation queue

2024-11-04 Thread Michael S. Tsirkin
On Mon, Nov 04, 2024 at 08:55:35PM +0800, Zhenzhong Duan wrote: > According to VTD spec, a 256-bit descriptor will result in an invalid > descriptor error if submitted in an IQ that is setup to provide hardware > with 128-bit descriptors (IQA_REG.DW=0). Meanwhile, there are old inv desc > types (e.

[PATCH 2/3] intel_iommu: Add missed sanity check for 256-bit invalidation queue

2024-11-04 Thread Zhenzhong Duan
According to VTD spec, a 256-bit descriptor will result in an invalid descriptor error if submitted in an IQ that is setup to provide hardware with 128-bit descriptors (IQA_REG.DW=0). Meanwhile, there are old inv desc types (e.g. iotlb_inv_desc) that can be either 128bits or 256bits. If a 128-bit v