Re: [PATCH 2/3] hw/timer/xilinx_timer.c: Switch to transaction-based ptimer API

2019-10-17 Thread Alistair Francis
On Thu, Oct 17, 2019 at 6:50 AM Peter Maydell wrote: > > Switch the xilinx_timer code away from bottom-half based ptimers to > the new transaction-based ptimer API. This just requires adding > begin/commit calls around the various places that modify the ptimer > state, and using the new ptimer_in

Re: [PATCH 2/3] hw/timer/xilinx_timer.c: Switch to transaction-based ptimer API

2019-10-17 Thread Philippe Mathieu-Daudé
On 10/17/19 5:03 PM, Peter Maydell wrote: On Thu, 17 Oct 2019 at 15:57, Philippe Mathieu-Daudé wrote: Hi Peter, On 10/17/19 3:21 PM, Peter Maydell wrote: +/* Must be called inside ptimer transaction block */ static void timer_enable(struct xlx_timer *xt) { uint64_t count; @@ -17

Re: [PATCH 2/3] hw/timer/xilinx_timer.c: Switch to transaction-based ptimer API

2019-10-17 Thread Peter Maydell
On Thu, 17 Oct 2019 at 15:57, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > On 10/17/19 3:21 PM, Peter Maydell wrote: > > +/* Must be called inside ptimer transaction block */ > > static void timer_enable(struct xlx_timer *xt) > > { > > uint64_t count; > > @@ -174,8 +173,11 @@ timer_wr

Re: [PATCH 2/3] hw/timer/xilinx_timer.c: Switch to transaction-based ptimer API

2019-10-17 Thread Philippe Mathieu-Daudé
Hi Peter, On 10/17/19 3:21 PM, Peter Maydell wrote: Switch the xilinx_timer code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() func

Re: [PATCH 2/3] hw/timer/xilinx_timer.c: Switch to transaction-based ptimer API

2019-10-17 Thread Richard Henderson
On 10/17/19 6:21 AM, Peter Maydell wrote: > Switch the xilinx_timer code away from bottom-half based ptimers to > the new transaction-based ptimer API. This just requires adding > begin/commit calls around the various places that modify the ptimer > state, and using the new ptimer_init() function

[PATCH 2/3] hw/timer/xilinx_timer.c: Switch to transaction-based ptimer API

2019-10-17 Thread Peter Maydell
Switch the xilinx_timer code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to create the timer. Signed-off-by: Peter Maydell