Re: [PATCH 2/3] block/copy-before-write: add on-cbw-error open parameter

2022-03-09 Thread Vladimir Sementsov-Ogievskiy
01.03.2022 23:59, Vladimir Sementsov-Ogievskiy wrote: @@ -273,9 +311,9 @@ cbw_co_snapshot_block_status(BlockDriverState *bs, assert(ret & BDRV_BLOCK_ALLOCATED); } -cbw_snapshot_read_unlock(bs, req); +ret2 = cbw_snapshot_read_unlock(bs, req); -return ret; +r

[PATCH 2/3] block/copy-before-write: add on-cbw-error open parameter

2022-03-01 Thread Vladimir Sementsov-Ogievskiy
Currently, behavior on copy-before-write operation failure is simple: report error to the guest. Let's implement alternative behavior: break the whole copy-before-write process (and corresponding backup job or NBD client) but keep guest working. It's needed if we consider guest stability as more i