Re: [PATCH 2/2] virtio-gpu: fix scanout migration post-load

2024-01-17 Thread Sebastian Ott
On Wed, 17 Jan 2024, Marc-André Lureau wrote: On Tue, Jan 16, 2024 at 3:17 PM Sebastian Ott wrote: On Mon, 15 Jan 2024, marcandre.lur...@redhat.com wrote: +scanout->ds = qemu_create_displaysurface_pixman(res->image); +if (!scanout->ds) { +return -EINVAL;

Re: [PATCH 2/2] virtio-gpu: fix scanout migration post-load

2024-01-17 Thread Marc-André Lureau
Hi On Tue, Jan 16, 2024 at 3:17 PM Sebastian Ott wrote: > > On Mon, 15 Jan 2024, marcandre.lur...@redhat.com wrote: > > +scanout->ds = qemu_create_displaysurface_pixman(res->image); > > +if (!scanout->ds) { > > +return -EINVAL; > > +} > > "qemu_

Re: [PATCH 2/2] virtio-gpu: fix scanout migration post-load

2024-01-16 Thread Sebastian Ott
On Mon, 15 Jan 2024, marcandre.lur...@redhat.com wrote: +scanout->ds = qemu_create_displaysurface_pixman(res->image); +if (!scanout->ds) { +return -EINVAL; +} "qemu_create_displaysurface_pixman() never returns NULL." ;-)

[PATCH 2/2] virtio-gpu: fix scanout migration post-load

2024-01-15 Thread marcandre . lureau
From: Marc-André Lureau The current post-loading code for scanout has a FIXME: it doesn't take the resource region/rect into account. But there is more, when adding blob migration support in commit f66767f75c9, I didn't realize that blob resources could be used for scanouts. This situationn leads