Re: [PATCH 2/2] util/meson: Build iov/hexdump/buffer_is_zero with virtiofsd

2021-04-28 Thread Philippe Mathieu-Daudé
On 4/28/21 9:24 PM, Richard Henderson wrote: > On 4/28/21 10:56 AM, Philippe Mathieu-Daudé wrote: >> Are you suggesting to remove the 'if have_block' check? This makes build >> a the files pointlessly for user-mode-only builds... > > But since the objects are not included in the binary, I don't ca

Re: [PATCH 2/2] util/meson: Build iov/hexdump/buffer_is_zero with virtiofsd

2021-04-28 Thread Richard Henderson
On 4/28/21 10:56 AM, Philippe Mathieu-Daudé wrote: Are you suggesting to remove the 'if have_block' check? This makes build a the files pointlessly for user-mode-only builds... But since the objects are not included in the binary, I don't care. The build system is already too complex, and buil

Re: [PATCH 2/2] util/meson: Build iov/hexdump/buffer_is_zero with virtiofsd

2021-04-28 Thread Philippe Mathieu-Daudé
On 4/28/21 6:38 PM, Richard Henderson wrote: > On 4/28/21 7:48 AM, Philippe Mathieu-Daudé wrote: >> diff --git a/util/meson.build b/util/meson.build >> index 510765cde46..c2eda2d1374 100644 >> --- a/util/meson.build >> +++ b/util/meson.build >> @@ -59,12 +59,10 @@ >>     util_ss.add(files('aiocb.c'

Re: [PATCH 2/2] util/meson: Build iov/hexdump/buffer_is_zero with virtiofsd

2021-04-28 Thread Richard Henderson
On 4/28/21 7:48 AM, Philippe Mathieu-Daudé wrote: diff --git a/util/meson.build b/util/meson.build index 510765cde46..c2eda2d1374 100644 --- a/util/meson.build +++ b/util/meson.build @@ -59,12 +59,10 @@ util_ss.add(files('aiocb.c', 'async.c', 'aio-wait.c')) util_ss.add(files('base64.c'))

[PATCH 2/2] util/meson: Build iov/hexdump/buffer_is_zero with virtiofsd

2021-04-28 Thread Philippe Mathieu-Daudé
When not explicitly select a sysemu target or the QEMU tools and building virtiofsd, libqemuutil.a has missing symbols: /usr/bin/ld: tools/virtiofsd/virtiofsd.p/fuse_virtio.c.o: in function `virtio_send_msg': tools/virtiofsd/fuse_virtio.c:236: undefined reference to `iov_size' /usr/bin/ld:

Re: [PATCH 2/2] util/meson: Build iov/hexdump/buffer_is_zero with virtiofsd

2021-04-28 Thread Philippe Mathieu-Daudé
On 4/28/21 4:48 PM, Philippe Mathieu-Daudé wrote: > When not explicitly select a sysemu target or the QEMU tools and > building virtiofsd, libqemuutil.a has missing symbols: > > /usr/bin/ld: tools/virtiofsd/virtiofsd.p/fuse_virtio.c.o: in function > `virtio_send_msg': > tools/virtiofsd/fuse_v