Re: [PATCH 2/2] python/qemu: Change ConsoleSocket to optionally drain socket.

2020-07-16 Thread Robert Foley
On Thu, 16 Jul 2020 at 09:42, Alex Bennée wrote: > > > +self._drain_thread = None > > +socket.socket.__init__(self, socket.AF_UNIX, socket.SOCK_STREAM) > > +self.connect(address) > > +self._drain = drain > > We end up with two variables that represent the fact we h

Re: [PATCH 2/2] python/qemu: Change ConsoleSocket to optionally drain socket.

2020-07-16 Thread Alex Bennée
Robert Foley writes: > The primary purpose of this change is to clean up > machine.py's console_socket property to return a single type, > a ConsoleSocket. > > ConsoleSocket now derives from a socket, which means that > in the default case (of not draining), machine.py > will see the same behav

[PATCH 2/2] python/qemu: Change ConsoleSocket to optionally drain socket.

2020-07-15 Thread Robert Foley
The primary purpose of this change is to clean up machine.py's console_socket property to return a single type, a ConsoleSocket. ConsoleSocket now derives from a socket, which means that in the default case (of not draining), machine.py will see the same behavior as it did prior to ConsoleSocket.