Re: [PATCH 2/2] migration/compress: disable compress if failed to setup

2020-01-27 Thread Juan Quintela
Wei Yang wrote: > In current logic, if compress_threads_save_setup() returns -1 the whole > migration would fail, while we could handle it gracefully by disable > compress. > > Signed-off-by: Wei Yang Fully agree with Dave here. If user asks for compression, and compression fails, we fail migra

Re: [PATCH 2/2] migration/compress: disable compress if failed to setup

2019-11-07 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > In current logic, if compress_threads_save_setup() returns -1 the whole > migration would fail, while we could handle it gracefully by disable > compress. I think it's fine for migration to fail here; the user askd for compression - if it doesn't

[PATCH 2/2] migration/compress: disable compress if failed to setup

2019-10-11 Thread Wei Yang
In current logic, if compress_threads_save_setup() returns -1 the whole migration would fail, while we could handle it gracefully by disable compress. Signed-off-by: Wei Yang --- migration/migration.c | 9 + migration/migration.h | 1 + migration/ram.c | 15 --- 3 fil