Re: [PATCH 2/2] linux-user: Fix openat() emulation to not modify atime

2023-12-08 Thread Shu-Chun Weng
On Mon, Dec 4, 2023 at 8:58 AM Daniel P. Berrangé wrote: > On Thu, Nov 30, 2023 at 07:21:40PM -0800, Shu-Chun Weng wrote: > > Commit b8002058 strengthened openat()'s /proc detection by calling > > realpath(3) on the given path, which allows various paths and symlinks > > that points to the /proc

Re: [PATCH 2/2] linux-user: Fix openat() emulation to not modify atime

2023-12-04 Thread Daniel P . Berrangé
On Thu, Nov 30, 2023 at 07:21:40PM -0800, Shu-Chun Weng wrote: > Commit b8002058 strengthened openat()'s /proc detection by calling > realpath(3) on the given path, which allows various paths and symlinks > that points to the /proc file system to be intercepted correctly. > > Using realpath(3), th

Re: [PATCH 2/2] linux-user: Fix openat() emulation to not modify atime

2023-12-04 Thread Stefan Hajnoczi
On Mon, Dec 04, 2023 at 02:39:24PM +0100, Philippe Mathieu-Daudé wrote: > Hi Laurent, Helge, Richard, > > On 1/12/23 19:51, Shu-Chun Weng wrote: > > On Fri, Dec 1, 2023 at 4:42 AM Philippe Mathieu-Daudé > > wrote: > > > > Hi Shu-Chun, > > > > On 1/12/23 04:21,

Re: [PATCH 2/2] linux-user: Fix openat() emulation to not modify atime

2023-12-04 Thread Philippe Mathieu-Daudé
Hi Laurent, Helge, Richard, On 1/12/23 19:51, Shu-Chun Weng wrote: On Fri, Dec 1, 2023 at 4:42 AM Philippe Mathieu-Daudé > wrote: Hi Shu-Chun, On 1/12/23 04:21, Shu-Chun Weng wrote: > Commit b8002058 strengthened openat()'s /proc detection by calling

Re: [PATCH 2/2] linux-user: Fix openat() emulation to not modify atime

2023-12-01 Thread Shu-Chun Weng
On Fri, Dec 1, 2023 at 4:42 AM Philippe Mathieu-Daudé wrote: > Hi Shu-Chun, > > On 1/12/23 04:21, Shu-Chun Weng wrote: > > Commit b8002058 strengthened openat()'s /proc detection by calling > > realpath(3) on the given path, which allows various paths and symlinks > > that points to the /proc fil

Re: [PATCH 2/2] linux-user: Fix openat() emulation to not modify atime

2023-12-01 Thread Helge Deller
On 12/1/23 04:21, Shu-Chun Weng wrote: Commit b8002058 strengthened openat()'s /proc detection by calling realpath(3) on the given path, which allows various paths and symlinks that points to the /proc file system to be intercepted correctly. Using realpath(3), though, has a side effect that it

Re: [PATCH 2/2] linux-user: Fix openat() emulation to not modify atime

2023-12-01 Thread Philippe Mathieu-Daudé
Hi Shu-Chun, On 1/12/23 04:21, Shu-Chun Weng wrote: Commit b8002058 strengthened openat()'s /proc detection by calling realpath(3) on the given path, which allows various paths and symlinks that points to the /proc file system to be intercepted correctly. Using realpath(3), though, has a side e

[PATCH 2/2] linux-user: Fix openat() emulation to not modify atime

2023-11-30 Thread Shu-Chun Weng
Commit b8002058 strengthened openat()'s /proc detection by calling realpath(3) on the given path, which allows various paths and symlinks that points to the /proc file system to be intercepted correctly. Using realpath(3), though, has a side effect that it reads the symlinks along the way, and thu