On 8/30/23 02:34, Daniel Henrique Barboza wrote:
TBH I'm bothered why this doesn't work:
diff --git a/hw/intc/riscv_aplic.c b/hw/intc/riscv_aplic.c
index 592c3ce768..251e08ddc4 100644
--- a/hw/intc/riscv_aplic.c
+++ b/hw/intc/riscv_aplic.c
@@ -839,12 +839,16 @@ static void riscv_aplic_realize(D
On 8/29/23 22:26, Richard Henderson wrote:
On 8/29/23 16:51, Daniel Henrique Barboza wrote:
The compiler certainly does eliminate 0 && foo(), even at -O0.
There must be something else going on.
Pointer to your tree?
It's this tree:
https://github.com/alistair23/qemu/tree/riscv-to-apply.ne
On 8/29/23 16:51, Daniel Henrique Barboza wrote:
The compiler certainly does eliminate 0 && foo(), even at -O0.
There must be something else going on.
Pointer to your tree?
It's this tree:
https://github.com/alistair23/qemu/tree/riscv-to-apply.next
Ok, so while -O0 will eliminate 0 && foo(
On 8/29/23 20:30, Richard Henderson wrote:
On 8/29/23 16:09, Daniel Henrique Barboza wrote:
-- >8 --
diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
@@ -79,7 +79,9 @@
/* KVM AIA only supports APLIC MSI. APLIC Wired is always emulated by QEMU. */
static bool virt_use_kvm_aia(RISCVVirtState
On 8/29/23 16:09, Daniel Henrique Barboza wrote:
-- >8 --
diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
@@ -79,7 +79,9 @@
/* KVM AIA only supports APLIC MSI. APLIC Wired is always emulated by QEMU. */
static bool virt_use_kvm_aia(RISCVVirtState *s)
{
- return kvm_irqchip_in_kernel() &&
On 8/29/23 11:18, Philippe Mathieu-Daudé wrote:
On 29/8/23 14:21, Daniel Henrique Barboza wrote:
A build with --enable-debug and without KVM will fail as follows:
/usr/bin/ld: libqemu-riscv64-softmmu.fa.p/hw_riscv_virt.c.o: in function
`virt_machine_init':
./qemu/build/../hw/riscv/virt.c:14
On 29/8/23 14:21, Daniel Henrique Barboza wrote:
A build with --enable-debug and without KVM will fail as follows:
/usr/bin/ld: libqemu-riscv64-softmmu.fa.p/hw_riscv_virt.c.o: in function
`virt_machine_init':
./qemu/build/../hw/riscv/virt.c:1465: undefined reference to
`kvm_riscv_aia_create'
A build with --enable-debug and without KVM will fail as follows:
/usr/bin/ld: libqemu-riscv64-softmmu.fa.p/hw_riscv_virt.c.o: in function
`virt_machine_init':
./qemu/build/../hw/riscv/virt.c:1465: undefined reference to
`kvm_riscv_aia_create'
This happens because the code block with "if virt_u
