Re: [PATCH 2/2] hw/nvme: move device-scoped functions

2021-02-23 Thread Minwoo Im
On 21-02-09 12:08:26, Klaus Jensen wrote: > From: Klaus Jensen > > Move a bunch of functions that are internal to a device out of the > shared header. > > Signed-off-by: Klaus Jensen > --- > hw/nvme/nvme.h | 110 + > hw/nvme/ctrl.c | 90

Re: [PATCH 2/2] hw/nvme: move device-scoped functions

2021-02-10 Thread Klaus Jensen
On Feb 11 11:55, Minwoo Im wrote: > On 21-02-09 12:08:26, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Move a bunch of functions that are internal to a device out of the > > shared header. > > May I ask why? I think some kind of these helpers can stick onto the > header. I just thought t

Re: [PATCH 2/2] hw/nvme: move device-scoped functions

2021-02-10 Thread Minwoo Im
On 21-02-09 12:08:26, Klaus Jensen wrote: > From: Klaus Jensen > > Move a bunch of functions that are internal to a device out of the > shared header. May I ask why? I think some kind of these helpers can stick onto the header.

[PATCH 2/2] hw/nvme: move device-scoped functions

2021-02-09 Thread Klaus Jensen
From: Klaus Jensen Move a bunch of functions that are internal to a device out of the shared header. Signed-off-by: Klaus Jensen --- hw/nvme/nvme.h | 110 + hw/nvme/ctrl.c | 90 +++- hw/nvme/ns.c | 7 +++-