Re: [PATCH 2/2] dump-guest-memory: Block live migration

2021-08-25 Thread Peter Xu
On Wed, Aug 25, 2021 at 11:36:08AM +0400, Marc-André Lureau wrote: > Shouldn't this be placed earlier in the function, before > runstate_is_running() and vm_stop() ? Good point... Will respin, thanks! -- Peter Xu

Re: [PATCH 2/2] dump-guest-memory: Block live migration

2021-08-25 Thread Marc-André Lureau
Hi On Tue, Aug 24, 2021 at 7:27 PM Peter Xu wrote: > Both dump-guest-memory and live migration caches vm state at the beginning. > Either of them entering the other one will cause race on the vm state, and > even > more severe on that (please refer to the crash report in the bug link). > > Let's

Re: [PATCH 2/2] dump-guest-memory: Block live migration

2021-08-24 Thread Peter Xu
On Tue, Aug 24, 2021 at 10:04:19PM +0400, Marc-André Lureau wrote: > Hi Hello, Marc-Andre, > > On Tue, Aug 24, 2021 at 7:27 PM Peter Xu wrote: > > > Both dump-guest-memory and live migration caches vm state at the beginning. > > Either of them entering the other one will cause race on the vm s

Re: [PATCH 2/2] dump-guest-memory: Block live migration

2021-08-24 Thread Marc-André Lureau
Hi On Tue, Aug 24, 2021 at 7:27 PM Peter Xu wrote: > Both dump-guest-memory and live migration caches vm state at the beginning. > Either of them entering the other one will cause race on the vm state, and > even > more severe on that (please refer to the crash report in the bug link). > > Let's

[PATCH 2/2] dump-guest-memory: Block live migration

2021-08-24 Thread Peter Xu
Both dump-guest-memory and live migration caches vm state at the beginning. Either of them entering the other one will cause race on the vm state, and even more severe on that (please refer to the crash report in the bug link). Let's block live migration in dump-guest-memory, and that'll also bloc