Re: [PATCH 2/2] block: assert that permission commit sets same permissions

2020-11-24 Thread Vladimir Sementsov-Ogievskiy
23.11.2020 23:12, Vladimir Sementsov-Ogievskiy wrote: On permission update commit we must set same permissions as on_check_. Let's add assertions. Next step may be to drop permission parameters from_set_. Note that prior to previous commit, fixing bdrv_drop_intermediate(), new assertion in bdrv_

[PATCH 2/2] block: assert that permission commit sets same permissions

2020-11-23 Thread Vladimir Sementsov-Ogievskiy
On permission update commit we must set same permissions as on _check_. Let's add assertions. Next step may be to drop permission parameters from _set_. Note that prior to previous commit, fixing bdrv_drop_intermediate(), new assertion in bdrv_child_set_perm() crashes on iotests 30 and 40. Signed

Re: [PATCH 2/2] block: assert that permission commit sets same permissions

2020-11-05 Thread Max Reitz
On 31.10.20 13:35, Vladimir Sementsov-Ogievskiy wrote: On permission update commit we must set same permissions as on _check_. Let's add assertions. Next step may be to drop permission parameters from _set_. Note that prior to previous commit, fixing bdrv_drop_intermediate(), new assertion in bd

Re: [PATCH 2/2] block: assert that permission commit sets same permissions

2020-10-31 Thread Vladimir Sementsov-Ogievskiy
31.10.2020 15:35, Vladimir Sementsov-Ogievskiy wrote: On permission update commit we must set same permissions as on _check_. Let's add assertions. Next step may be to drop permission parameters from _set_. Note that prior to previous commit, fixing bdrv_drop_intermediate(), new assertion in bdr

[PATCH 2/2] block: assert that permission commit sets same permissions

2020-10-31 Thread Vladimir Sementsov-Ogievskiy
On permission update commit we must set same permissions as on _check_. Let's add assertions. Next step may be to drop permission parameters from _set_. Note that prior to previous commit, fixing bdrv_drop_intermediate(), new assertion in bdrv_child_set_perm() crashes on iotests 30 and 40. Signed