Re: [PATCH 19/26] hw/intc/arm_gicv3_its: Don't use data if reading command failed

2021-12-13 Thread Alex Bennée
Peter Maydell writes: > In process_cmdq(), we read 64 bits of the command packet, which > contain the command identifier, which we then switch() on to dispatch > to an appropriate sub-function. However, if address_space_ldq_le() > reports a memory transaction failure, we still read the command

Re: [PATCH 19/26] hw/intc/arm_gicv3_its: Don't use data if reading command failed

2021-12-12 Thread Richard Henderson
On 12/11/21 11:11 AM, Peter Maydell wrote: In process_cmdq(), we read 64 bits of the command packet, which contain the command identifier, which we then switch() on to dispatch to an appropriate sub-function. However, if address_space_ldq_le() reports a memory transaction failure, we still read

[PATCH 19/26] hw/intc/arm_gicv3_its: Don't use data if reading command failed

2021-12-11 Thread Peter Maydell
In process_cmdq(), we read 64 bits of the command packet, which contain the command identifier, which we then switch() on to dispatch to an appropriate sub-function. However, if address_space_ldq_le() reports a memory transaction failure, we still read the command identifier out of the data and sw