Re: [PATCH 18/22] tcg/riscv: Convert to tcg-target-conset.h

2021-01-07 Thread Peter Maydell
On Thu, 7 Jan 2021 at 19:15, Richard Henderson wrote: > > On 1/7/21 8:08 AM, Peter Maydell wrote: > > (Also "conset.h" looks really like a typo for "const.h" which > > is kinda confusing :-)) > > Naming suggestions? :-) tcg-target-con-set.h ? -- PMM

Re: [PATCH 18/22] tcg/riscv: Convert to tcg-target-conset.h

2021-01-07 Thread Richard Henderson
On 1/7/21 8:08 AM, Peter Maydell wrote: > (Also "conset.h" looks really like a typo for "const.h" which > is kinda confusing :-)) Naming suggestions? :-) r~

Re: [PATCH 18/22] tcg/riscv: Convert to tcg-target-conset.h

2021-01-07 Thread Philippe Mathieu-Daudé
On 1/7/21 7:08 PM, Peter Maydell wrote: > On Wed, 23 Dec 2020 at 06:25, Richard Henderson > wrote: >> >> Signed-off-by: Richard Henderson >> --- >> tcg/riscv/tcg-target-conset.h | 25 +++ >> tcg/riscv/tcg-target.h| 1 + >> tcg/riscv/tcg-target.c.inc| 83 ++---

Re: [PATCH 18/22] tcg/riscv: Convert to tcg-target-conset.h

2021-01-07 Thread Peter Maydell
On Wed, 23 Dec 2020 at 06:25, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > tcg/riscv/tcg-target-conset.h | 25 +++ > tcg/riscv/tcg-target.h| 1 + > tcg/riscv/tcg-target.c.inc| 83 ++- > 3 files changed, 49 insertions(+

Re: [PATCH 18/22] tcg/riscv: Convert to tcg-target-conset.h

2021-01-07 Thread Alistair Francis
On Tue, Dec 22, 2020 at 10:23 PM Richard Henderson wrote: > > Signed-off-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- > tcg/riscv/tcg-target-conset.h | 25 +++ > tcg/riscv/tcg-target.h| 1 + > tcg/riscv/tcg-target.c.inc| 83 ++---

[PATCH 18/22] tcg/riscv: Convert to tcg-target-conset.h

2020-12-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/riscv/tcg-target-conset.h | 25 +++ tcg/riscv/tcg-target.h| 1 + tcg/riscv/tcg-target.c.inc| 83 ++- 3 files changed, 49 insertions(+), 60 deletions(-) create mode 100644 tcg/riscv/tcg-target-conset.h