Re: [PATCH 16/19] target/arm: Add arm_cpu_has_feature() helper

2025-05-15 Thread Pierrick Bouvier
On 5/15/25 9:14 AM, Philippe Mathieu-Daudé wrote: On 15/5/25 17:22, Pierrick Bouvier wrote: On 5/15/25 4:05 AM, Philippe Mathieu-Daudé wrote: On 14/5/25 18:59, Pierrick Bouvier wrote: On 5/14/25 9:53 AM, Philippe Mathieu-Daudé wrote: On 14/5/25 10:24, Richard Henderson wrote: On 5/13/25 18:3

Re: [PATCH 16/19] target/arm: Add arm_cpu_has_feature() helper

2025-05-15 Thread Philippe Mathieu-Daudé
On 15/5/25 17:22, Pierrick Bouvier wrote: On 5/15/25 4:05 AM, Philippe Mathieu-Daudé wrote: On 14/5/25 18:59, Pierrick Bouvier wrote: On 5/14/25 9:53 AM, Philippe Mathieu-Daudé wrote: On 14/5/25 10:24, Richard Henderson wrote: On 5/13/25 18:39, Philippe Mathieu-Daudé wrote: arm_cpu_has_featu

Re: [PATCH 16/19] target/arm: Add arm_cpu_has_feature() helper

2025-05-15 Thread Pierrick Bouvier
On 5/15/25 4:05 AM, Philippe Mathieu-Daudé wrote: On 14/5/25 18:59, Pierrick Bouvier wrote: On 5/14/25 9:53 AM, Philippe Mathieu-Daudé wrote: On 14/5/25 10:24, Richard Henderson wrote: On 5/13/25 18:39, Philippe Mathieu-Daudé wrote: arm_cpu_has_feature() is equivalent of arm_feature(), howeve

Re: [PATCH 16/19] target/arm: Add arm_cpu_has_feature() helper

2025-05-15 Thread Philippe Mathieu-Daudé
On 14/5/25 18:59, Pierrick Bouvier wrote: On 5/14/25 9:53 AM, Philippe Mathieu-Daudé wrote: On 14/5/25 10:24, Richard Henderson wrote: On 5/13/25 18:39, Philippe Mathieu-Daudé wrote: arm_cpu_has_feature() is equivalent of arm_feature(), however while the latter uses CPUARMState so is target-sp

Re: [PATCH 16/19] target/arm: Add arm_cpu_has_feature() helper

2025-05-14 Thread Pierrick Bouvier
On 5/14/25 9:53 AM, Philippe Mathieu-Daudé wrote: On 14/5/25 10:24, Richard Henderson wrote: On 5/13/25 18:39, Philippe Mathieu-Daudé wrote: arm_cpu_has_feature() is equivalent of arm_feature(), however while the latter uses CPUARMState so is target-specific, the former doesn't and can be calle

Re: [PATCH 16/19] target/arm: Add arm_cpu_has_feature() helper

2025-05-14 Thread Philippe Mathieu-Daudé
On 14/5/25 10:24, Richard Henderson wrote: On 5/13/25 18:39, Philippe Mathieu-Daudé wrote: arm_cpu_has_feature() is equivalent of arm_feature(), however while the latter uses CPUARMState so is target-specific, the former doesn't and can be called by target-agnostic code in hw/. CPUARMState is

Re: [PATCH 16/19] target/arm: Add arm_cpu_has_feature() helper

2025-05-14 Thread Richard Henderson
On 5/13/25 18:39, Philippe Mathieu-Daudé wrote: arm_cpu_has_feature() is equivalent of arm_feature(), however while the latter uses CPUARMState so is target-specific, the former doesn't and can be called by target-agnostic code in hw/. CPUARMState is no more target-specific than ARMCPU. Did yo

[PATCH 16/19] target/arm: Add arm_cpu_has_feature() helper

2025-05-13 Thread Philippe Mathieu-Daudé
arm_cpu_has_feature() is equivalent of arm_feature(), however while the latter uses CPUARMState so is target-specific, the former doesn't and can be called by target-agnostic code in hw/. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Pierrick Bouvier --- target/arm/cpu_has_feature.h | 2 ++