Re: [PATCH 16/17] spapr_pci: Drop some dead error handling

2020-04-29 Thread Philippe Mathieu-Daudé
On 4/28/20 6:34 PM, Markus Armbruster wrote: chassis_from_bus() uses object_property_get_uint() to get property "chassis_nr" of the bridge device. Failure would be a programming error. Pass &error_abort, and simplify its callers. Cc: David Gibson Cc: qemu-...@nongnu.org Signed-off-by: Markus

Re: [PATCH 16/17] spapr_pci: Drop some dead error handling

2020-04-29 Thread Greg Kurz
On Tue, 28 Apr 2020 18:34:18 +0200 Markus Armbruster wrote: > chassis_from_bus() uses object_property_get_uint() to get property > "chassis_nr" of the bridge device. Failure would be a programming > error. Pass &error_abort, and simplify its callers. > > Cc: David Gibson > Cc: qemu-...@nongnu

Re: [PATCH 16/17] spapr_pci: Drop some dead error handling

2020-04-28 Thread David Gibson
On Tue, Apr 28, 2020 at 06:34:18PM +0200, Markus Armbruster wrote: > chassis_from_bus() uses object_property_get_uint() to get property > "chassis_nr" of the bridge device. Failure would be a programming > error. Pass &error_abort, and simplify its callers. > > Cc: David Gibson > Cc: qemu-...@n

[PATCH 16/17] spapr_pci: Drop some dead error handling

2020-04-28 Thread Markus Armbruster
chassis_from_bus() uses object_property_get_uint() to get property "chassis_nr" of the bridge device. Failure would be a programming error. Pass &error_abort, and simplify its callers. Cc: David Gibson Cc: qemu-...@nongnu.org Signed-off-by: Markus Armbruster --- hw/ppc/spapr_pci.c | 86 ++