Re: [PATCH 14/16] target/arm: Implement ESB instruction

2022-04-12 Thread Richard Henderson
On 4/12/22 02:56, Peter Maydell wrote: On Mon, 11 Apr 2022 at 23:14, Richard Henderson wrote: On 4/11/22 09:18, Peter Maydell wrote: + ESB 0011 0010 0001 +] Why don't we decode bits [11:8] here? I see it's the same as YIELD/WFE/WFI, but I'm not sure

Re: [PATCH 14/16] target/arm: Implement ESB instruction

2022-04-12 Thread Peter Maydell
On Mon, 11 Apr 2022 at 23:14, Richard Henderson wrote: > > On 4/11/22 09:18, Peter Maydell wrote: > >> + ESB 0011 0010 0001 > >> +] > > > > Why don't we decode bits [11:8] here? I see it's the same > > as YIELD/WFE/WFI, but I'm not sure why we're not decodi

Re: [PATCH 14/16] target/arm: Implement ESB instruction

2022-04-11 Thread Richard Henderson
On 4/11/22 09:18, Peter Maydell wrote: + ESB 0011 0010 0001 +] Why don't we decode bits [11:8] here? I see it's the same as YIELD/WFE/WFI, but I'm not sure why we're not decoding those bits in those insns either... See page F4-7074 in H.a, where bits [

Re: [PATCH 14/16] target/arm: Implement ESB instruction

2022-04-11 Thread Peter Maydell
On Sat, 9 Apr 2022 at 01:18, Richard Henderson wrote: > > Check for and defer any pending virtual SError. > > Signed-off-by: Richard Henderson > --- > target/arm/helper.h| 1 + > target/arm/a32.decode | 16 +- > target/arm/t32.decode | 18 +++ > target/

[PATCH 14/16] target/arm: Implement ESB instruction

2022-04-08 Thread Richard Henderson
Check for and defer any pending virtual SError. Signed-off-by: Richard Henderson --- target/arm/helper.h| 1 + target/arm/a32.decode | 16 +- target/arm/t32.decode | 18 +++ target/arm/op_helper.c | 45 ++ target/