Re: [PATCH 14/14] qapi: Require boxed for conditional command and event arguments

2023-03-16 Thread Eric Blake
On Thu, Mar 16, 2023 at 08:13:25AM +0100, Markus Armbruster wrote: > The C code generator fails to honor 'if' conditions of command and > event arguments. > ... > > Conditional arguments work fine with 'boxed': true, simply because > complex types with conditional members work fine. Not worth bre

[PATCH 14/14] qapi: Require boxed for conditional command and event arguments

2023-03-16 Thread Markus Armbruster
The C code generator fails to honor 'if' conditions of command and event arguments. For instance, tests/qapi-schema/qapi-schema-test.json has { 'event': 'TEST_IF_EVENT', 'data': { 'foo': 'TestIfStruct', 'bar': { 'type': ['str'], 'if': 'TEST_IF_EVT_ARG' } }, 'if': {