Re: [PATCH 139/147] meson: replace create-config with meson configure_file

2020-08-11 Thread Alexander Bulekov
On 200811 1916, Paolo Bonzini wrote: > On 11/08/20 19:12, Alexander Bulekov wrote: > > On 200811 1825, Philippe Mathieu-Daudé wrote: > >> On 8/11/20 6:20 PM, Philippe Mathieu-Daudé wrote: > >>> On 8/10/20 7:08 PM, Paolo Bonzini wrote: > Move the create-config logic to meson.build; create a > >

Re: [PATCH 139/147] meson: replace create-config with meson configure_file

2020-08-11 Thread Paolo Bonzini
On 11/08/20 18:25, Philippe Mathieu-Daudé wrote: > Alexander reported [*] a problem when ARRAY_SIZE(whitelist_rw) == 0 you > access an undefined address: But that's not accessing an undefined address, it's taking the address past the last item---which should be okay. And I cannot reproduce it wit

Re: [PATCH 139/147] meson: replace create-config with meson configure_file

2020-08-11 Thread Paolo Bonzini
On 11/08/20 19:12, Alexander Bulekov wrote: > On 200811 1825, Philippe Mathieu-Daudé wrote: >> On 8/11/20 6:20 PM, Philippe Mathieu-Daudé wrote: >>> On 8/10/20 7:08 PM, Paolo Bonzini wrote: Move the create-config logic to meson.build; create a configuration_data object and let meson handl

Re: [PATCH 139/147] meson: replace create-config with meson configure_file

2020-08-11 Thread Alexander Bulekov
On 200811 1825, Philippe Mathieu-Daudé wrote: > On 8/11/20 6:20 PM, Philippe Mathieu-Daudé wrote: > > On 8/10/20 7:08 PM, Paolo Bonzini wrote: > >> Move the create-config logic to meson.build; create a > >> configuration_data object and let meson handle the > >> quoting and output. > >> > >> Signed

Re: [PATCH 139/147] meson: replace create-config with meson configure_file

2020-08-11 Thread Philippe Mathieu-Daudé
On 8/11/20 6:20 PM, Philippe Mathieu-Daudé wrote: > On 8/10/20 7:08 PM, Paolo Bonzini wrote: >> Move the create-config logic to meson.build; create a >> configuration_data object and let meson handle the >> quoting and output. >> >> Signed-off-by: Paolo Bonzini >> --- >> Makefile

Re: [PATCH 139/147] meson: replace create-config with meson configure_file

2020-08-11 Thread Philippe Mathieu-Daudé
On 8/10/20 7:08 PM, Paolo Bonzini wrote: > Move the create-config logic to meson.build; create a > configuration_data object and let meson handle the > quoting and output. > > Signed-off-by: Paolo Bonzini > --- > Makefile | 2 +- > block.c| 4 +-

[PATCH 139/147] meson: replace create-config with meson configure_file

2020-08-10 Thread Paolo Bonzini
Move the create-config logic to meson.build; create a configuration_data object and let meson handle the quoting and output. Signed-off-by: Paolo Bonzini --- Makefile | 2 +- block.c| 4 +- configure | 9 ++- meson.build