Re: [PATCH 13/36] vl: move semihosting command line fallback to qemu_init_board

2020-11-27 Thread Paolo Bonzini
On 27/11/20 13:12, Igor Mammedov wrote: Fair enough, I'd put -semihosting-config in the same bucket as -m/-boot/-smp (machine configuration that isn't in -M) so I'll move it together with them. it might be machine code, but I didn't see anything that depends on machine in there that's why I've s

Re: [PATCH 13/36] vl: move semihosting command line fallback to qemu_init_board

2020-11-27 Thread Igor Mammedov
On Fri, 27 Nov 2020 12:22:51 +0100 Paolo Bonzini wrote: > On 27/11/20 11:31, Igor Mammedov wrote: > >> Yes, calling it around machine initialization time is also a > >> possibility. I just wanted to get rid of it in code that I'm actually > >> looking at.:) > > I'd prefer it being moved close

Re: [PATCH 13/36] vl: move semihosting command line fallback to qemu_init_board

2020-11-27 Thread Paolo Bonzini
On 27/11/20 11:31, Igor Mammedov wrote: Yes, calling it around machine initialization time is also a possibility. I just wanted to get rid of it in code that I'm actually looking at.:) I'd prefer it being moved close to CLI parsing, in a place where other _early call go. We probably want qemu_

Re: [PATCH 13/36] vl: move semihosting command line fallback to qemu_init_board

2020-11-27 Thread Igor Mammedov
On Fri, 27 Nov 2020 06:03:43 +0100 Paolo Bonzini wrote: > On 26/11/20 18:10, Igor Mammedov wrote: > > On Mon, 23 Nov 2020 09:14:12 -0500 > > Paolo Bonzini wrote: > > > >> Move more sane parts of the huge qemu_init function out of it. > >> > >> Signed-off-by: Paolo Bonzini > >> --- > >> sof

Re: [PATCH 13/36] vl: move semihosting command line fallback to qemu_init_board

2020-11-26 Thread Paolo Bonzini
On 26/11/20 18:10, Igor Mammedov wrote: On Mon, 23 Nov 2020 09:14:12 -0500 Paolo Bonzini wrote: Move more sane parts of the huge qemu_init function out of it. Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/sof

Re: [PATCH 13/36] vl: move semihosting command line fallback to qemu_init_board

2020-11-26 Thread Igor Mammedov
On Mon, 23 Nov 2020 09:14:12 -0500 Paolo Bonzini wrote: > Move more sane parts of the huge qemu_init function out of it. > > Signed-off-by: Paolo Bonzini > --- > softmmu/vl.c | 12 +--- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/softmmu/vl.c b/softmmu/vl.c > in

[PATCH 13/36] vl: move semihosting command line fallback to qemu_init_board

2020-11-23 Thread Paolo Bonzini
Move more sane parts of the huge qemu_init function out of it. Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index ab08a0290c..5d68cf828c 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -