On 12/1/19 11:07 PM, Markus Armbruster wrote:
{
+Error *err = NULL;
I remember that some time ago, the best practice was to use "local_err",
what is the latest state of that?
Hundreds of local Error * variables are named @local_err, and hundreds
more are named @err.
For what it's wor
David Hildenbrand writes:
> On 30.11.19 20:42, Markus Armbruster wrote:
>> memory_device_get_free_addr() crashes when
>> memory_device_check_addable() fails and its @errp argument is null.
>> Messed up in commit 1b6d6af21b "pc-dimm: factor out capacity and slot
>> checks into MemoryDevice".
>>
>
On 30.11.19 20:42, Markus Armbruster wrote:
> memory_device_get_free_addr() crashes when
> memory_device_check_addable() fails and its @errp argument is null.
> Messed up in commit 1b6d6af21b "pc-dimm: factor out capacity and slot
> checks into MemoryDevice".
>
> The bug can't bite as no caller ac
memory_device_get_free_addr() crashes when
memory_device_check_addable() fails and its @errp argument is null.
Messed up in commit 1b6d6af21b "pc-dimm: factor out capacity and slot
checks into MemoryDevice".
The bug can't bite as no caller actually passes null. Fix it anyway.
Cc: David Hildenbra
