Re: [PATCH 13/16] qapi/expr.py: Modify check_keys to accept any Iterable

2020-09-24 Thread Cleber Rosa
On Tue, Sep 22, 2020 at 05:13:10PM -0400, John Snow wrote: > This is a very minor adjustment. > > a + b is list-specific behavior, but we can accept a wider variety of > types in a more pythonic fashion if we avoid that behavior. > > Typing it this way allows callers to use things like dict.keys(

Re: [PATCH 13/16] qapi/expr.py: Modify check_keys to accept any Iterable

2020-09-23 Thread Eduardo Habkost
On Tue, Sep 22, 2020 at 05:13:10PM -0400, John Snow wrote: > This is a very minor adjustment. > > a + b is list-specific behavior, but we can accept a wider variety of > types in a more pythonic fashion if we avoid that behavior. > > Typing it this way allows callers to use things like dict.keys(

[PATCH 13/16] qapi/expr.py: Modify check_keys to accept any Iterable

2020-09-22 Thread John Snow
This is a very minor adjustment. a + b is list-specific behavior, but we can accept a wider variety of types in a more pythonic fashion if we avoid that behavior. Typing it this way allows callers to use things like dict.keys() and other iterables that are not their own discrete lists. Including