Re: [PATCH 13/14] qapi: Fix code generated for optional conditional struct member

2023-03-16 Thread Eric Blake
On Thu, Mar 16, 2023 at 08:13:24AM +0100, Markus Armbruster wrote: > The generated member visit neglects to emit #if around a conditional > struct member's has_ variable. For instance, > tests/qapi-schema/qapi-schema-test.json generates > > #if defined(TEST_IF_STRUCT) > bool visit_type_Te

[PATCH 13/14] qapi: Fix code generated for optional conditional struct member

2023-03-16 Thread Markus Armbruster
The generated member visit neglects to emit #if around a conditional struct member's has_ variable. For instance, tests/qapi-schema/qapi-schema-test.json generates #if defined(TEST_IF_STRUCT) bool visit_type_TestIfStruct_members(Visitor *v, TestIfStruct *obj, Error **errp) { --->