Re: [PATCH 10/21] migration: Use QAPI_CLONE_MEMBERS in query_migrate_parameters

2025-06-13 Thread Fabiano Rosas
Peter Xu writes: > On Thu, Jun 12, 2025 at 05:58:14PM -0300, Fabiano Rosas wrote: >> Fabiano Rosas writes: >> >> > Peter Xu writes: >> > >> >> On Mon, Jun 02, 2025 at 10:37:59PM -0300, Fabiano Rosas wrote: >> >>> QAPI_CLONE_MEMBERS is a better option than copying parameters one by >> >>> one b

Re: [PATCH 10/21] migration: Use QAPI_CLONE_MEMBERS in query_migrate_parameters

2025-06-12 Thread Peter Xu
On Thu, Jun 12, 2025 at 05:58:14PM -0300, Fabiano Rosas wrote: > Fabiano Rosas writes: > > > Peter Xu writes: > > > >> On Mon, Jun 02, 2025 at 10:37:59PM -0300, Fabiano Rosas wrote: > >>> QAPI_CLONE_MEMBERS is a better option than copying parameters one by > >>> one because it operates on the en

Re: [PATCH 10/21] migration: Use QAPI_CLONE_MEMBERS in query_migrate_parameters

2025-06-12 Thread Fabiano Rosas
Fabiano Rosas writes: > Peter Xu writes: > >> On Mon, Jun 02, 2025 at 10:37:59PM -0300, Fabiano Rosas wrote: >>> QAPI_CLONE_MEMBERS is a better option than copying parameters one by >>> one because it operates on the entire struct and follows pointers. It >>> also avoids the need to alter this f

Re: [PATCH 10/21] migration: Use QAPI_CLONE_MEMBERS in query_migrate_parameters

2025-06-06 Thread Peter Xu
On Mon, Jun 02, 2025 at 10:37:59PM -0300, Fabiano Rosas wrote: > QAPI_CLONE_MEMBERS is a better option than copying parameters one by > one because it operates on the entire struct and follows pointers. It > also avoids the need to alter this function every time a new parameter > is added. > > Not

Re: [PATCH 10/21] migration: Use QAPI_CLONE_MEMBERS in query_migrate_parameters

2025-06-06 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Jun 02, 2025 at 10:37:59PM -0300, Fabiano Rosas wrote: >> QAPI_CLONE_MEMBERS is a better option than copying parameters one by >> one because it operates on the entire struct and follows pointers. It >> also avoids the need to alter this function every time a new parame

[PATCH 10/21] migration: Use QAPI_CLONE_MEMBERS in query_migrate_parameters

2025-06-02 Thread Fabiano Rosas
QAPI_CLONE_MEMBERS is a better option than copying parameters one by one because it operates on the entire struct and follows pointers. It also avoids the need to alter this function every time a new parameter is added. Note, since this is a deep clone, now we must free the TLS strings before assi