[Qemu-devel] Re: [PATCH 1 of 2] kvm: Move KVM mp_state accessors to i386-specific code

2009-11-09 Thread Anthony Liguori
Jan Kiszka wrote: Hollis Blanchard wrote: Unbreaks PowerPC and S390 KVM builds. What breaks precisely? Note that KVM_GET/SET_MP_STATE are generic IOCTLs and supposed to be shared with ia64 - one day. We could still move things back then, but maybe we can handle the build issues alread

Re: [PATCH 1 of 2] kvm: Move KVM mp_state accessors to i386-specific code

2009-11-09 Thread Jan Kiszka
Hollis Blanchard wrote: > This is the technique Anthony requested this morning, rather than > relocating mp_state. Then let's move it. There is not that much code to share anyway. > To be honest, I don't care which way it's fixed; > this is at least the 3rd patch to solve this seemingly trivial >

[Qemu-devel] Re: [PATCH 1 of 2] kvm: Move KVM mp_state accessors to i386-specific code

2009-11-09 Thread Hollis Blanchard
This is the technique Anthony requested this morning, rather than relocating mp_state. To be honest, I don't care which way it's fixed; this is at least the 3rd patch to solve this seemingly trivial problem. /home/hollisb/source/qemu-fresh.hg/kvm-all.c: In function 'kvm_put_mp_state': /home/hollis

Re: [PATCH 1 of 2] kvm: Move KVM mp_state accessors to i386-specific code

2009-11-09 Thread Alexander Graf
On 09.11.2009, at 23:12, Jan Kiszka wrote: Hollis Blanchard wrote: Unbreaks PowerPC and S390 KVM builds. What breaks precisely? Note that KVM_GET/SET_MP_STATE are generic IOCTLs and supposed to be shared with ia64 - one day. We could still move things back then, but maybe we can handle the

Re: [PATCH 1 of 2] kvm: Move KVM mp_state accessors to i386-specific code

2009-11-09 Thread Jan Kiszka
Hollis Blanchard wrote: > Unbreaks PowerPC and S390 KVM builds. What breaks precisely? Note that KVM_GET/SET_MP_STATE are generic IOCTLs and supposed to be shared with ia64 - one day. We could still move things back then, but maybe we can handle the build issues already in place, specifically as

[PATCH 1 of 2] kvm: Move KVM mp_state accessors to i386-specific code

2009-11-09 Thread Hollis Blanchard
Unbreaks PowerPC and S390 KVM builds. Signed-off-by: Hollis Blanchard diff --git a/kvm-all.c b/kvm-all.c --- a/kvm-all.c +++ b/kvm-all.c @@ -207,26 +207,6 @@ err: return ret; } -int kvm_put_mp_state(CPUState *env) -{ -struct kvm_mp_state mp_state = { .mp_state = env->mp_state }; - -