RE: [PATCH 1/6] target/xtensa: fix uninitialized variable warning

2020-11-03 Thread Chenqun (kuhn)
> -Original Message- > From: Max Filippov [mailto:jcmvb...@gmail.com] > Sent: Tuesday, November 3, 2020 5:22 PM > To: Chenqun (kuhn) > Cc: qemu-devel ; QEMU Trivial > ; Zhanghailiang > ; ganqixin ; Euler > Robot > Subject: Re: [PATCH 1/6] target/xtensa: fix uni

Re: [PATCH 1/6] target/xtensa: fix uninitialized variable warning

2020-11-03 Thread Max Filippov
On Mon, Nov 2, 2020 at 5:52 PM Chen Qun wrote: > > The compiler cannot determine whether the return values of the > xtensa_operand_is_register(isa, opc, opnd) > and xtensa_operand_is_visible(isa, opc, opnd) functions are the same. It doesn't have to because 1) they definitely are not the same,

Re: [PATCH 1/6] target/xtensa: fix uninitialized variable warning

2020-11-02 Thread Philippe Mathieu-Daudé
On 11/3/20 2:52 AM, Chen Qun wrote: > The compiler cannot determine whether the return values of the > xtensa_operand_is_register(isa, opc, opnd) > and xtensa_operand_is_visible(isa, opc, opnd) functions are the same. > So,it assumes that 'rf' is not assigned, but it's used. > > The compiler sho

[PATCH 1/6] target/xtensa: fix uninitialized variable warning

2020-11-02 Thread Chen Qun
The compiler cannot determine whether the return values of the xtensa_operand_is_register(isa, opc, opnd) and xtensa_operand_is_visible(isa, opc, opnd) functions are the same. So,it assumes that 'rf' is not assigned, but it's used. The compiler showed warning: target/xtensa/translate.c: In funct