Re: [PATCH 1/6] target/microblaze: Use the IEC binary prefix definitions

2021-06-03 Thread Alistair Francis
On Thu, Jun 3, 2021 at 7:03 PM Philippe Mathieu-Daudé wrote: > > IEC binary prefixes ease code review: the unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > target/microblaze/mmu.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deleti

Re: [PATCH 1/6] target/microblaze: Use the IEC binary prefix definitions

2021-06-03 Thread Richard Henderson
On 6/3/21 2:03 AM, Philippe Mathieu-Daudé wrote: static unsigned int tlb_decode_size(unsigned int f) { static const unsigned int sizes[] = { -1 * 1024, 4 * 1024, 16 * 1024, 64 * 1024, 256 * 1024, -1 * 1024 * 1024, 4 * 1024 * 1024, 16 * 1024 * 1024 +1 * KiB, 4 * K

Re: [PATCH 1/6] target/microblaze: Use the IEC binary prefix definitions

2021-06-03 Thread Edgar E. Iglesias
On Thu, Jun 03, 2021 at 11:03:05AM +0200, Philippe Mathieu-Daudé wrote: > IEC binary prefixes ease code review: the unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Edgar E. Iglesias > --- > target/microblaze/mmu.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 dele

[PATCH 1/6] target/microblaze: Use the IEC binary prefix definitions

2021-06-03 Thread Philippe Mathieu-Daudé
IEC binary prefixes ease code review: the unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- target/microblaze/mmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target/microblaze/mmu.c b/target/microblaze/mmu.c index cc40f275eaf..1481e2769f1 100644 --- a/tar