Re: [PATCH 1/6] dma/pl330: Convert to support tracing

2020-01-17 Thread Guenter Roeck
On Fri, Jan 17, 2020 at 05:05:07PM +, Peter Maydell wrote: > On Fri, 17 Jan 2020 at 16:46, Guenter Roeck wrote: > > > > On Fri, Jan 17, 2020 at 01:23:46PM +, Peter Maydell wrote: > > > Won't this now do all the work of constructing the hexdump strings, > > > even if tracing is disabled ? >

Re: [PATCH 1/6] dma/pl330: Convert to support tracing

2020-01-17 Thread Peter Maydell
On Fri, 17 Jan 2020 at 16:46, Guenter Roeck wrote: > > On Fri, Jan 17, 2020 at 01:23:46PM +, Peter Maydell wrote: > > Won't this now do all the work of constructing the hexdump strings, > > even if tracing is disabled ? > > > That is correct. Can I check > if (trace_event_get_state(TRA

Re: [PATCH 1/6] dma/pl330: Convert to support tracing

2020-01-17 Thread Guenter Roeck
On Fri, Jan 17, 2020 at 01:23:46PM +, Peter Maydell wrote: > On Fri, 10 Jan 2020 at 20:39, Guenter Roeck wrote: > > > > Replace debug logging code with tracing. > > > > Signed-off-by: Guenter Roeck > > --- > > hw/dma/pl330.c | 88 +++-- > > hw/dma

Re: [PATCH 1/6] dma/pl330: Convert to support tracing

2020-01-17 Thread Peter Maydell
On Fri, 10 Jan 2020 at 20:39, Guenter Roeck wrote: > > Replace debug logging code with tracing. > > Signed-off-by: Guenter Roeck > --- > hw/dma/pl330.c | 88 +++-- > hw/dma/trace-events | 24 + > +static void pl330_hexdump(uint8_t *buf, si

[PATCH 1/6] dma/pl330: Convert to support tracing

2020-01-10 Thread Guenter Roeck
Replace debug logging code with tracing. Signed-off-by: Guenter Roeck --- hw/dma/pl330.c | 88 +++-- hw/dma/trace-events | 24 + 2 files changed, 70 insertions(+), 42 deletions(-) diff --git a/hw/dma/pl330.c b/hw/dma/pl330.c index f2bb2d9