Re: [PATCH 1/5] configure: Add missing POSIX-required space

2022-07-20 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > In commit 7d7dbf9dc15be6e1 we added a line to the configure script > which is not valid POSIX shell syntax, because it is missing a space > after a '!' character. shellcheck diagnoses this: > > if !(GIT="$git" "$source_path/scripts/git-submodule.

Re: [PATCH 1/5] configure: Add missing POSIX-required space

2022-07-20 Thread Thomas Huth
On 20/07/2022 17.26, Peter Maydell wrote: In commit 7d7dbf9dc15be6e1 we added a line to the configure script which is not valid POSIX shell syntax, because it is missing a space after a '!' character. shellcheck diagnoses this: if !(GIT="$git" "$source_path/scripts/git-submodule.sh" "$git_submod

[PATCH 1/5] configure: Add missing POSIX-required space

2022-07-20 Thread Peter Maydell
In commit 7d7dbf9dc15be6e1 we added a line to the configure script which is not valid POSIX shell syntax, because it is missing a space after a '!' character. shellcheck diagnoses this: if !(GIT="$git" "$source_path/scripts/git-submodule.sh" "$git_submodules_action" "$git_submodules"); then ^