Re: [PATCH 1/4] target/mips: Add declarations for generic TCG helpers

2021-06-28 Thread Richard Henderson
On 6/28/21 9:33 AM, Philippe Mathieu-Daudé wrote: I don't mind the ordering, just that there's a reason. Is that OK if I reword as: --- We want to extract the microMIPS ISA and Code Compaction ASE to new compilation units. We will first extract this code as included source files (.c.inc), the

Re: [PATCH 1/4] target/mips: Add declarations for generic TCG helpers

2021-06-28 Thread Philippe Mathieu-Daudé
Hi Richard, On 6/19/21 2:41 PM, Richard Henderson wrote: > On 6/19/21 2:26 AM, Philippe Mathieu-Daudé wrote: >>>    It doesn't seem to match the next >>> two patches, which don't create new compilation units. >> >> Indeed. In a yet-to-be-posted later series they get renamed to .c, >> becoming new

Re: [PATCH 1/4] target/mips: Add declarations for generic TCG helpers

2021-06-19 Thread Richard Henderson
On 6/19/21 2:26 AM, Philippe Mathieu-Daudé wrote:   It doesn't seem to match the next two patches, which don't create new compilation units. Indeed. In a yet-to-be-posted later series they get renamed to .c, becoming new units. Ah, ok. What I can do is hold these patches and post them late

Re: [PATCH 1/4] target/mips: Add declarations for generic TCG helpers

2021-06-19 Thread Philippe Mathieu-Daudé
On 6/18/21 10:15 PM, Richard Henderson wrote: > On 6/17/21 10:49 AM, Philippe Mathieu-Daudé wrote: >> To be able to extract the microMIPS ISA and Code Compaction ASE >> translation routines to different source files, declare few TCG >> helpers which are also used by translate.c in "translate.h". >>

Re: [PATCH 1/4] target/mips: Add declarations for generic TCG helpers

2021-06-18 Thread Richard Henderson
On 6/17/21 10:49 AM, Philippe Mathieu-Daudé wrote: To be able to extract the microMIPS ISA and Code Compaction ASE translation routines to different source files, declare few TCG helpers which are also used by translate.c in "translate.h". Signed-off-by: Philippe Mathieu-Daudé --- target/mips/

[PATCH 1/4] target/mips: Add declarations for generic TCG helpers

2021-06-17 Thread Philippe Mathieu-Daudé
To be able to extract the microMIPS ISA and Code Compaction ASE translation routines to different source files, declare few TCG helpers which are also used by translate.c in "translate.h". Signed-off-by: Philippe Mathieu-Daudé --- target/mips/tcg/translate.h | 5 + target/mips/tcg/translate.