Re: [PATCH 1/3] tests/qtest/vhost-user-test: use share=on with memfd

On Mon, Mar 08, 2021 at 07:31:25AM +0100, Thomas Huth wrote: > On 22/02/2021 17.10, Stefan Hajnoczi wrote: > > For some reason memfd never used share=on. vhost-user relies on > > mmap(MAP_SHARED) so this seems like a problem, but the tests still run > > without it. > > > > Add share=on for consist

Re: [PATCH 1/3] tests/qtest/vhost-user-test: use share=on with memfd

On 22/02/2021 17.10, Stefan Hajnoczi wrote: For some reason memfd never used share=on. vhost-user relies on mmap(MAP_SHARED) so this seems like a problem, but the tests still run without it. Add share=on for consistency and to prevent future bugs in the test. Signed-off-by: Stefan Hajnoczi ---

Re: [PATCH 1/3] tests/qtest/vhost-user-test: use share=on with memfd

On Wed, Feb 24, 2021 at 02:22:31PM +0400, Marc-André Lureau wrote: > Hi > > On Mon, Feb 22, 2021 at 8:11 PM Stefan Hajnoczi wrote: > > > For some reason memfd never used share=on. vhost-user relies on > > mmap(MAP_SHARED) so this seems like a problem, but the tests still run > > without it. > >

Re: [PATCH 1/3] tests/qtest/vhost-user-test: use share=on with memfd

Hi On Mon, Feb 22, 2021 at 8:11 PM Stefan Hajnoczi wrote: > For some reason memfd never used share=on. vhost-user relies on > mmap(MAP_SHARED) so this seems like a problem, but the tests still run > without it. > > Simply because it's on by default with memory-backend-memfd (it wouldn't make muc

[PATCH 1/3] tests/qtest/vhost-user-test: use share=on with memfd

For some reason memfd never used share=on. vhost-user relies on mmap(MAP_SHARED) so this seems like a problem, but the tests still run without it. Add share=on for consistency and to prevent future bugs in the test. Signed-off-by: Stefan Hajnoczi --- tests/qtest/vhost-user-test.c | 2 +- 1 file