Re: [PATCH 1/3] target/riscv/tcg: restrict satp_mode changes in cpu_set_profile

2025-05-28 Thread Alistair Francis
On Wed, May 21, 2025 at 3:24 AM Daniel Henrique Barboza wrote: > > We're changing 'mmu' to true regardless of whether the profile is > being enabled or not, and at the same time we're changing satp_mode to > profile->enabled. > > This will promote a situation where we'll set mmu=on without a virtu

Re: [PATCH 1/3] target/riscv/tcg: restrict satp_mode changes in cpu_set_profile

2025-05-21 Thread Andrew Jones
On Tue, May 20, 2025 at 02:23:34PM -0300, Daniel Henrique Barboza wrote: > We're changing 'mmu' to true regardless of whether the profile is > being enabled or not, and at the same time we're changing satp_mode to > profile->enabled. > > This will promote a situation where we'll set mmu=on without

Re: [PATCH 1/3] target/riscv/tcg: restrict satp_mode changes in cpu_set_profile

2025-05-21 Thread Björn Töpel
Daniel Henrique Barboza writes: > We're changing 'mmu' to true regardless of whether the profile is > being enabled or not, and at the same time we're changing satp_mode to > profile->enabled. > > This will promote a situation where we'll set mmu=on without a virtual > memory mode, which is a mis

[PATCH 1/3] target/riscv/tcg: restrict satp_mode changes in cpu_set_profile

2025-05-20 Thread Daniel Henrique Barboza
We're changing 'mmu' to true regardless of whether the profile is being enabled or not, and at the same time we're changing satp_mode to profile->enabled. This will promote a situation where we'll set mmu=on without a virtual memory mode, which is a mistake. Only touch 'mmu' and satp_mode if the