Re: [PATCH 1/3] rust/memory: replace size arg with Bits enum

2025-07-08 Thread Zhao Liu
On Thu, Jul 03, 2025 at 04:58:11PM +0300, Manos Pitsidianakis wrote: > Date: Thu, 03 Jul 2025 16:58:11 +0300 > From: Manos Pitsidianakis > Subject: [PATCH 1/3] rust/memory: replace size arg with Bits enum > X-Mailer: b4 0.14.2 > > We have the ability to make memory accesses use

Re: [PATCH 1/3] rust/memory: replace size arg with Bits enum

2025-07-08 Thread Zhao Liu
On Thu, Jul 03, 2025 at 04:58:11PM +0300, Manos Pitsidianakis wrote: > Date: Thu, 03 Jul 2025 16:58:11 +0300 > From: Manos Pitsidianakis > Subject: [PATCH 1/3] rust/memory: replace size arg with Bits enum > X-Mailer: b4 0.14.2 > > We have the ability to make memory accesses use

Re: [PATCH 1/3] rust/memory: replace size arg with Bits enum

2025-07-08 Thread Paolo Bonzini
We have the ability to make memory accesses use a typesafe access width type in Rust, which the C API currently lacks as it does not use a newtype wrapper for specifying the amount of bytes a memory access has; it uses a plain 32-bit integer value instead. I find this both verbose and (ok, that'

Re: [PATCH 1/3] rust/memory: replace size arg with Bits enum

2025-07-08 Thread Paolo Bonzini
Il mar 8 lug 2025, 11:11 Manos Pitsidianakis ha scritto: > > I find this both verbose and (ok, that's subjective) ugly due to the > > extra import, the underscore. > > Yep, I agree on that, but I wasn't sure what name would be better. > Whatever type-level improvement this patch brings, it's smal

Re: [PATCH 1/3] rust/memory: replace size arg with Bits enum

2025-07-08 Thread Manos Pitsidianakis
On Tue, Jul 8, 2025 at 11:35 AM Paolo Bonzini wrote: > > > We have the ability to make memory accesses use a typesafe access width > > type in Rust, which the C API currently lacks as it does not use a > > newtype wrapper for specifying the amount of bytes a memory access has; > > it uses a plain

[PATCH 1/3] rust/memory: replace size arg with Bits enum

2025-07-03 Thread Manos Pitsidianakis
We have the ability to make memory accesses use a typesafe access width type in Rust, which the C API currently lacks as it does not use a newtype wrapper for specifying the amount of bytes a memory access has; it uses a plain 32-bit integer value instead. Replace use of u32 size arguments with a