Re: [PATCH 1/3] qga: test: Use absolute path to test data

2023-02-27 Thread Daniel Xu
Hi Marc-André, Thanks for reviewing the series. On Mon, Feb 27, 2023, at 1:16 AM, Marc-André Lureau wrote: > Hi > > On Fri, Feb 24, 2023 at 8:31 AM Daniel Xu wrote: >> >> It looks like qga's working directory is in a tempdir. So the relative >> path that the test case gives qga through the QGA_O

Re: [PATCH 1/3] qga: test: Use absolute path to test data

2023-02-27 Thread Marc-André Lureau
Hi On Fri, Feb 24, 2023 at 8:31 AM Daniel Xu wrote: > > It looks like qga's working directory is in a tempdir. So the relative > path that the test case gives qga through the QGA_OS_RELEASE= > env variable does not resolve correctly. > > Fix by doing a poor man's path canonicalization of the test

[PATCH 1/3] qga: test: Use absolute path to test data

2023-02-23 Thread Daniel Xu
It looks like qga's working directory is in a tempdir. So the relative path that the test case gives qga through the QGA_OS_RELEASE= env variable does not resolve correctly. Fix by doing a poor man's path canonicalization of the test data file. Note we cannot use g_canonicalize_filename() b/c tha