Hi Peter,
Thanks for the comments.
Updated in v2.
Note: I have included a null check in the fail statement of
migration coroutine as well.
This is so that there are no dereferencing
issue in case local_err is not set in any of the paths.
(error_report_err call dereferences the err->msg)
On Wed,
On Wed, Jun 25, 2025 at 05:24:10PM +0530, Arun Menon wrote:
> Hi Peter,
Hi, Arun,
[...]
> > > static void vmstate_save_old_style(QEMUFile *f, SaveStateEntry *se,
> > > @@ -2071,6 +2072,7 @@ static void *postcopy_ram_listen_thread(void
> > > *opaque)
> > > {
> > > MigrationIncomingState *
Hi Peter,
Thank you so much for the review.
I shall squash patches 1 and 2 and add error_prepend()
where I missed them; also adding a null check.
On Tue, Jun 24, 2025 at 09:46:48AM -0400, Peter Xu wrote:
> Hi, Arun,
>
> On Tue, Jun 24, 2025 at 05:53:04PM +0530, Arun Menon wrote:
> > - This is an
Hi, Arun,
On Tue, Jun 24, 2025 at 05:53:04PM +0530, Arun Menon wrote:
> - This is an incremental step in converting vmstate loading
> code to report errors.
> - Minimal changes to the signature and body of the following
> functions are done,
> - vmstate_load()
> - vmstate_load_state()
>
- This is an incremental step in converting vmstate loading
code to report errors.
- Minimal changes to the signature and body of the following
functions are done,
- vmstate_load()
- vmstate_load_state()
- vmstate_subsection_load()
- qemu_load_device_state()
- qemu_loadvm_state()
-
