Re: [PATCH 1/3] hw/pci-host/designware: Remove unused include

2025-05-06 Thread Philippe Mathieu-Daudé
On 6/5/25 15:03, Peter Maydell wrote: On Thu, 1 May 2025 at 20:02, Philippe Mathieu-Daudé wrote: On 1/5/25 20:34, Bernhard Beschow wrote: The DEFINE_TYPES() macro doesn't need the qemu/module.h include. Fixes: 13a07eb146c8 ("hw/pci-host/designware: Declare CPU QOM types using DEFINE_TYPES()

Re: [PATCH 1/3] hw/pci-host/designware: Remove unused include

2025-05-06 Thread Peter Maydell
On Thu, 1 May 2025 at 20:02, Philippe Mathieu-Daudé wrote: > > On 1/5/25 20:34, Bernhard Beschow wrote: > > The DEFINE_TYPES() macro doesn't need the qemu/module.h include. > > > > Fixes: 13a07eb146c8 ("hw/pci-host/designware: Declare CPU QOM types using > > DEFINE_TYPES() macro") > > The 'Fixes:'

Re: [PATCH 1/3] hw/pci-host/designware: Remove unused include

2025-05-01 Thread BALATON Zoltan
On Thu, 1 May 2025, Philippe Mathieu-Daudé wrote: On 1/5/25 20:34, Bernhard Beschow wrote: The DEFINE_TYPES() macro doesn't need the qemu/module.h include. Fixes: 13a07eb146c8 ("hw/pci-host/designware: Declare CPU QOM types using DEFINE_TYPES() macro") The 'Fixes:' tag is for bug being fixed.

Re: [PATCH 1/3] hw/pci-host/designware: Remove unused include

2025-05-01 Thread Bernhard Beschow
Am 1. Mai 2025 19:02:35 UTC schrieb "Philippe Mathieu-Daudé" : >On 1/5/25 20:34, Bernhard Beschow wrote: >> The DEFINE_TYPES() macro doesn't need the qemu/module.h include. >> >> Fixes: 13a07eb146c8 ("hw/pci-host/designware: Declare CPU QOM types using >> DEFINE_TYPES() macro") > >The 'Fixes:'

Re: [PATCH 1/3] hw/pci-host/designware: Remove unused include

2025-05-01 Thread Philippe Mathieu-Daudé
On 1/5/25 20:34, Bernhard Beschow wrote: The DEFINE_TYPES() macro doesn't need the qemu/module.h include. Fixes: 13a07eb146c8 ("hw/pci-host/designware: Declare CPU QOM types using DEFINE_TYPES() macro") The 'Fixes:' tag is for bug being fixed. Here I suggest: Since commit 13a07eb146c8 ("hw/

[PATCH 1/3] hw/pci-host/designware: Remove unused include

2025-05-01 Thread Bernhard Beschow
The DEFINE_TYPES() macro doesn't need the qemu/module.h include. Fixes: 13a07eb146c8 ("hw/pci-host/designware: Declare CPU QOM types using DEFINE_TYPES() macro") Signed-off-by: Bernhard Beschow --- hw/pci-host/designware.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/pci-host/designware