Re: [PATCH 1/3] arm: move KVM breakpoints helpers

2022-11-09 Thread Francesco Cagnin
> I was planning to move hypervisor-specific code to target/arm/$hypervisor/, > but here Francesco wants to re-use the same code > between 2 hypervisors... Maybe move it to target/arm/hyp_gdbstub.c > and let meson add it conditionally? Something like this? -arm_ss.add(when: 'CONFIG_KVM', if_true

Re: [PATCH 1/3] arm: move KVM breakpoints helpers

2022-11-07 Thread Philippe Mathieu-Daudé
On 7/11/22 15:15, Alex Bennée wrote: francesco.cag...@gmail.com writes: From: Francesco Cagnin These helpers will be also used for HVF. Aside from reformatting a couple of comments for 'checkpatch.pl', this is just code motion. Signed-off-by: Francesco Cagnin --- target/arm/debug_helper.

Re: [PATCH 1/3] arm: move KVM breakpoints helpers

2022-11-07 Thread Alex Bennée
francesco.cag...@gmail.com writes: > From: Francesco Cagnin > > These helpers will be also used for HVF. Aside from reformatting a > couple of comments for 'checkpatch.pl', this is just code motion. > > Signed-off-by: Francesco Cagnin > --- > target/arm/debug_helper.c | 241 ++

Re: [PATCH 1/3] arm: move KVM breakpoints helpers

2022-11-07 Thread Mads Ynddal
> On 4 Nov 2022, at 19.40, francesco.cag...@gmail.com wrote: > > From: Francesco Cagnin > > These helpers will be also used for HVF. Aside from reformatting a > couple of comments for 'checkpatch.pl', this is just code motion. > > Signed-off-by: Francesco Cagnin > --- > target/arm/debug_help

[PATCH 1/3] arm: move KVM breakpoints helpers

2022-11-04 Thread francesco . cagnin
From: Francesco Cagnin These helpers will be also used for HVF. Aside from reformatting a couple of comments for 'checkpatch.pl', this is just code motion. Signed-off-by: Francesco Cagnin --- target/arm/debug_helper.c | 241 + target/arm/internals.h| 50 +++