Re: [PATCH 1/2] virtio-gpu: add virtio-gpu-pci module

2020-10-25 Thread Gerd Hoffmann
Hi, > > commit 501093207eb1ed4845e0a65ee1ce7db7b9676e0b > > Author: Gerd Hoffmann > > Date: Wed Sep 23 11:12:17 2020 +0200 > > > > module: silence errors for module_load_qom_all(). > > > Ok, but that could hide real errors, couldn't it? It should not. If you explicitly ask for an module

Re: [PATCH 1/2] virtio-gpu: add virtio-gpu-pci module

2020-10-23 Thread Marc-André Lureau
HI On Fri, Oct 23, 2020 at 3:01 PM Gerd Hoffmann wrote: > Hi, > > > Hmm, I realize we have a different behaviour when building devices as > > modules shared by different qemu system binaries. > > > > It will attempt to load any kind of modules: > > > > ./qemu-system-m68k -kernel ~/Downloads/v

Re: [PATCH 1/2] virtio-gpu: add virtio-gpu-pci module

2020-10-23 Thread Gerd Hoffmann
Hi, > Hmm, I realize we have a different behaviour when building devices as > modules shared by different qemu system binaries. > > It will attempt to load any kind of modules: > > ./qemu-system-m68k -kernel ~/Downloads/vmlinux-5.8.0-3-m68k -device > virtio-gpu-pci > Failed to open module: >

Re: [PATCH 1/2] virtio-gpu: add virtio-gpu-pci module

2020-10-23 Thread Marc-André Lureau
On Fri, Oct 23, 2020 at 10:46 AM Gerd Hoffmann wrote: > Build virtio-gpu pci devices modular. Must be a separate module because > not all qemu softmmu variants come with PCI support. > > Signed-off-by: Gerd Hoffmann > Hmm, I realize we have a different behaviour when building devices as module

[PATCH 1/2] virtio-gpu: add virtio-gpu-pci module

2020-10-22 Thread Gerd Hoffmann
Build virtio-gpu pci devices modular. Must be a separate module because not all qemu softmmu variants come with PCI support. Signed-off-by: Gerd Hoffmann --- util/module.c | 3 +++ hw/display/meson.build | 11 +-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a