Re: [PATCH 1/2] virtio: reset region cache when on queue deletion

2020-01-07 Thread Yuri Benditovich
On Mon, Jan 6, 2020 at 12:37 PM Yuri Benditovich < yuri.benditov...@daynix.com> wrote: > > On Mon, Jan 6, 2020 at 11:58 AM Michael S. Tsirkin wrote: > >> I guess it somehow has to do with the following: >> >> if (proxy->disable_legacy == ON_OFF_AUTO_AUTO) { >> proxy->disable_legacy =

Re: [PATCH 1/2] virtio: reset region cache when on queue deletion

2020-01-06 Thread Yuri Benditovich
On Mon, Jan 6, 2020 at 11:58 AM Michael S. Tsirkin wrote: > I guess it somehow has to do with the following: > > if (proxy->disable_legacy == ON_OFF_AUTO_AUTO) { > proxy->disable_legacy = pcie_port ? ON_OFF_AUTO_ON : > ON_OFF_AUTO_OFF; > } > > so by default device on an express po

Re: [PATCH 1/2] virtio: reset region cache when on queue deletion

2020-01-06 Thread Michael S. Tsirkin
I guess it somehow has to do with the following: if (proxy->disable_legacy == ON_OFF_AUTO_AUTO) { proxy->disable_legacy = pcie_port ? ON_OFF_AUTO_ON : ON_OFF_AUTO_OFF; } so by default device on an express port does not have a legacy interface. Somehow having a legacy interface fi

Re: [PATCH 1/2] virtio: reset region cache when on queue deletion

2020-01-06 Thread Yuri Benditovich
Michael, Can you please comment on Jason's question: why we have a problem only with q35 and not with legacy pc? If you have a simple answer, it will help us in further work with other hot plug/unplug problems. Thanks, Yuri Benditovich On Sun, Jan 5, 2020 at 6:21 PM Yuri Benditovich wrote: > >

Re: [PATCH 1/2] virtio: reset region cache when on queue deletion

2020-01-05 Thread Yuri Benditovich
On Sun, Jan 5, 2020 at 1:39 PM Michael S. Tsirkin wrote: > On Thu, Jan 02, 2020 at 09:09:04AM +0200, Yuri Benditovich wrote: > > > > > > On Thu, Jan 2, 2020 at 1:50 AM Michael S. Tsirkin > wrote: > > > > On Thu, Dec 26, 2019 at 11:29:50AM +0200, Yuri Benditovich wrote: > > > On Thu, Dec

Re: [PATCH 1/2] virtio: reset region cache when on queue deletion

2020-01-05 Thread Yuri Benditovich
On Sun, Jan 5, 2020 at 2:22 PM Michael S. Tsirkin wrote: > On Thu, Dec 26, 2019 at 06:36:48AM +0200, Yuri Benditovich wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1708480 > > Fix leak of region reference that prevents complete > > device deletion on hot unplug. > > > > Signed-off-by: Yu

Re: [PATCH 1/2] virtio: reset region cache when on queue deletion

2020-01-05 Thread Michael S. Tsirkin
On Thu, Dec 26, 2019 at 06:36:48AM +0200, Yuri Benditovich wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1708480 > Fix leak of region reference that prevents complete > device deletion on hot unplug. > > Signed-off-by: Yuri Benditovich I rebased this on top of my tree. Got this: commit

Re: [PATCH 1/2] virtio: reset region cache when on queue deletion

2020-01-05 Thread Michael S. Tsirkin
On Thu, Jan 02, 2020 at 09:09:04AM +0200, Yuri Benditovich wrote: > > > On Thu, Jan 2, 2020 at 1:50 AM Michael S. Tsirkin wrote: > > On Thu, Dec 26, 2019 at 11:29:50AM +0200, Yuri Benditovich wrote: > > On Thu, Dec 26, 2019 at 10:58 AM Jason Wang wrote: > > > > > > > > > On

Re: [PATCH 1/2] virtio: reset region cache when on queue deletion

2020-01-01 Thread Yuri Benditovich
On Thu, Jan 2, 2020 at 1:50 AM Michael S. Tsirkin wrote: > On Thu, Dec 26, 2019 at 11:29:50AM +0200, Yuri Benditovich wrote: > > On Thu, Dec 26, 2019 at 10:58 AM Jason Wang wrote: > > > > > > > > > On 2019/12/26 下午12:36, Yuri Benditovich wrote: > > > > https://bugzilla.redhat.com/show_bug.cgi?id

Re: [PATCH 1/2] virtio: reset region cache when on queue deletion

2020-01-01 Thread Michael S. Tsirkin
On Thu, Dec 26, 2019 at 11:29:50AM +0200, Yuri Benditovich wrote: > On Thu, Dec 26, 2019 at 10:58 AM Jason Wang wrote: > > > > > > On 2019/12/26 下午12:36, Yuri Benditovich wrote: > > > https://bugzilla.redhat.com/show_bug.cgi?id=1708480 > > > Fix leak of region reference that prevents complete > >

Re: [PATCH 1/2] virtio: reset region cache when on queue deletion

2019-12-26 Thread Yuri Benditovich
On Thu, Dec 26, 2019 at 10:58 AM Jason Wang wrote: > > > On 2019/12/26 下午12:36, Yuri Benditovich wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1708480 > > Fix leak of region reference that prevents complete > > device deletion on hot unplug. > > > More information is needed here, the bug

Re: [PATCH 1/2] virtio: reset region cache when on queue deletion

2019-12-26 Thread Jason Wang
On 2019/12/26 下午12:36, Yuri Benditovich wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1708480 Fix leak of region reference that prevents complete device deletion on hot unplug. More information is needed here, the bug said only q35 can meet this issue. What makes q35 different here?

[PATCH 1/2] virtio: reset region cache when on queue deletion

2019-12-25 Thread Yuri Benditovich
https://bugzilla.redhat.com/show_bug.cgi?id=1708480 Fix leak of region reference that prevents complete device deletion on hot unplug. Signed-off-by: Yuri Benditovich --- hw/virtio/virtio.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 047